Normalize helper method signatures

Using groupKey instead of identifier as the latter can also apply to the pages

Author: emmadesilva

packages/framework/src/Framework/Features/Navigation/BaseMenuGenerator.php

@@ -104,17 +104,17 @@ protected function addRouteToGroup(Route $route): void
 
     protected function getOrCreateGroupItem(string $groupName): NavItem
     {
-        $identifier = Str::slug($groupName);
-        $group = $this->items->get($identifier);
+        $groupKey = Str::slug($groupName);
+        $group = $this->items->get($groupKey);
 
-        return $group ?? $this->createGroupItem($identifier, $groupName);
+        return $group ?? $this->createGroupItem($groupKey, $groupName);
     }
 
-    protected function createGroupItem(string $identifier, string $groupName): NavItem
+    protected function createGroupItem(string $groupKey, string $groupName): NavItem
     {
-        $label = $this->searchForGroupLabelInConfig($identifier) ?? $groupName;
+        $label = $this->searchForGroupLabelInConfig($groupKey) ?? $groupName;
 
-        $priority = $this->searchForGroupPriorityInConfig($identifier);
+        $priority = $this->searchForGroupPriorityInConfig($groupKey);
 
         return NavItem::dropdown($this->normalizeGroupLabel($label), [], $priority);
     }
@@ -129,11 +129,11 @@ protected function normalizeGroupLabel(string $label): string
         return $label;
     }
 
-    protected function searchForGroupLabelInConfig(string $identifier): ?string
+    protected function searchForGroupLabelInConfig(string $groupKey): ?string
     {
         $key = $this->generatesSidebar ? 'docs.sidebar_group_labels' : 'hyde.navigation.labels';
 
-        return Config::getArray($key, [])[$identifier] ?? null;
+        return Config::getArray($key, [])[$groupKey] ?? null;
     }
 
     protected function searchForGroupPriorityInConfig(string $groupKey): ?int