Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to check for empty public IP and/or private IP #3

Closed
hwdsl2 opened this issue Jan 23, 2016 · 0 comments
Closed

Failed to check for empty public IP and/or private IP #3

hwdsl2 opened this issue Jan 23, 2016 · 0 comments
Assignees
Labels

Comments

@hwdsl2
Copy link
Owner

hwdsl2 commented Jan 23, 2016

A bug was introduced in a previous commit 21629ae on Jan 14, 2016. It removed checks for empty public/private IP strings, in favor of checking against the correct IP regular expression. However, the grep command used in the IP regex checks had an error (the "-v" switch was used instead of negating the exit code). As a result, undefined or empty IP variables would pass the check, which is incorrect.

This bug has been fixed in commit b610351 on Jan 21, 2016. GitHub users @bjzhush and @Geoferry please update your forks to the latest version. Thanks!

@hwdsl2 hwdsl2 added the bug label Jan 23, 2016
@hwdsl2 hwdsl2 self-assigned this Jan 23, 2016
@hwdsl2 hwdsl2 closed this as completed Jan 23, 2016
@drMaxxi drMaxxi mentioned this issue Dec 31, 2018
@xyyxhcj xyyxhcj mentioned this issue Oct 1, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant