refactor: rewrite eslint config

Author: hussainweb

__tests__/grumphp.test.ts

@@ -2,29 +2,22 @@ import grumphp from '../src/checks/grumphp'
 import {expect, test} from '@jest/globals'
 
 test('it returns defaults', () => {
-  expect(grumphp({}, 'web')).toEqual([
-    'grumphp',
-    'run',
-    '--no-interaction'
-  ])
+  expect(grumphp({}, 'web')).toEqual(['grumphp', 'run', '--no-interaction'])
 })
 
 test('it handles partial inputs', () => {
   let command
   command = grumphp(
     {
-      testsuite: 'linters',
+      testsuite: 'linters'
     },
     'web'
   )
   expect(command).toContain('--testsuite=linters')
 
   command = grumphp(
     {
-      tasks: [
-        'phpcs',
-        'phpmd'
-      ]
+      tasks: ['phpcs', 'phpmd']
     },
     'docroot'
   )

__tests__/phpstan.test.ts

@@ -2,9 +2,7 @@ import phpstan from '../src/checks/phpstan'
 import {expect, test} from '@jest/globals'
 
 test('it returns defaults', () => {
-  expect(phpstan({}, 'web')).toEqual([
-    'phpstan'
-  ])
+  expect(phpstan({}, 'web')).toEqual(['phpstan'])
 })
 
 test('it handles configuration', () => {

eslint.config.mjs

@@ -1,89 +1,30 @@
-import jest from "eslint-plugin-jest";
-import typescriptEslint from "@typescript-eslint/eslint-plugin";
-import globals from "globals";
-import tsParser from "@typescript-eslint/parser";
-import path from "node:path";
-import { fileURLToPath } from "node:url";
-import js from "@eslint/js";
-import { FlatCompat } from "@eslint/eslintrc";
-
-const __filename = fileURLToPath(import.meta.url);
-const __dirname = path.dirname(__filename);
-const compat = new FlatCompat({
-    baseDirectory: __dirname,
-    recommendedConfig: js.configs.recommended,
-    allConfig: js.configs.all
-});
-
-export default [{
-    ignores: ["**/dist/", "**/lib/", "**/node_modules/", "**/jest.config.js"],
-}, ...compat.extends("plugin:github/recommended"), {
-    plugins: {
-        jest,
-        "@typescript-eslint": typescriptEslint,
-    },
-
+import eslint from '@eslint/js'
+import typescriptEslint from '@typescript-eslint/eslint-plugin'
+import tseslint from 'typescript-eslint'
+import jest from 'eslint-plugin-jest'
+import github from 'eslint-plugin-github'
+
+export default [
+  ...tseslint.config(eslint.configs.recommended, tseslint.configs.recommended),
+  github.getFlatConfigs().recommended,
+  {
+    rules: {
+      'importPlugin/no-unresolved': 'off'
+    }
+  },
+  ...github.getFlatConfigs().typescript,
+  {
+    files: ['__tests__/**/*.test.ts'],
+    plugins: {jest: jest},
     languageOptions: {
-        globals: {
-            ...globals.node,
-            ...jest.environments.globals.globals,
-        },
-
-        parser: tsParser,
-        ecmaVersion: 9,
-        sourceType: "module",
-
-        parserOptions: {
-            project: "./tsconfig.json",
-        },
+      globals: jest.environments.globals.globals
     },
-
     rules: {
-        "i18n-text/no-en": "off",
-        "eslint-comments/no-use": "off",
-        "import/no-namespace": "off",
-        "no-unused-vars": "off",
-        "@typescript-eslint/no-unused-vars": "error",
-
-        "@typescript-eslint/explicit-member-accessibility": ["error", {
-            accessibility: "no-public",
-        }],
-
-        "@typescript-eslint/no-require-imports": "error",
-        "@typescript-eslint/array-type": "error",
-        "@typescript-eslint/await-thenable": "error",
-        "@typescript-eslint/ban-ts-comment": "error",
-        camelcase: "off",
-        "@typescript-eslint/consistent-type-assertions": "error",
-
-        "@typescript-eslint/explicit-function-return-type": ["error", {
-            allowExpressions: true,
-        }],
-
-        "@typescript-eslint/func-call-spacing": ["error", "never"],
-        "@typescript-eslint/no-array-constructor": "error",
-        "@typescript-eslint/no-empty-interface": "error",
-        "@typescript-eslint/no-explicit-any": "error",
-        "@typescript-eslint/no-extraneous-class": "error",
-        "@typescript-eslint/no-for-in-array": "error",
-        "@typescript-eslint/no-inferrable-types": "error",
-        "@typescript-eslint/no-misused-new": "error",
-        "@typescript-eslint/no-namespace": "error",
-        "@typescript-eslint/no-non-null-assertion": "warn",
-        "@typescript-eslint/no-unnecessary-qualifier": "error",
-        "@typescript-eslint/no-unnecessary-type-assertion": "error",
-        "@typescript-eslint/no-useless-constructor": "error",
-        "@typescript-eslint/no-var-requires": "error",
-        "@typescript-eslint/prefer-for-of": "warn",
-        "@typescript-eslint/prefer-function-type": "warn",
-        "@typescript-eslint/prefer-includes": "error",
-        "@typescript-eslint/prefer-string-starts-ends-with": "error",
-        "@typescript-eslint/promise-function-async": "error",
-        "@typescript-eslint/require-array-sort-compare": "error",
-        "@typescript-eslint/restrict-plus-operands": "error",
-        semi: "off",
-        "@typescript-eslint/semi": ["error", "never"],
-        "@typescript-eslint/type-annotation-spacing": "error",
-        "@typescript-eslint/unbound-method": "error",
-    },
-}];
+      'jest/no-disabled-tests': 'warn',
+      'jest/no-focused-tests': 'error',
+      'jest/no-identical-title': 'error',
+      'jest/prefer-to-have-length': 'warn',
+      'jest/valid-expect': 'error'
+    }
+  }
+]

package-lock.json

@@ -29,7 +29,6 @@
     "yaml": "^2.5.0"
   },
   "devDependencies": {
-    "@eslint/eslintrc": "^3.2.0",
     "@eslint/js": "^9.17.0",
     "@types/node": "^20.14.10",
     "@typescript-eslint/parser": "^8.18.1",
@@ -38,7 +37,6 @@
     "eslint-plugin-github": "^5.1.4",
     "eslint-plugin-jest": "^28.10.0",
     "eslint-plugin-prettier": "^5.1.3",
-    "globals": "^15.14.0",
     "jest": "^29.7.0",
     "js-yaml": "^4.1.0",
     "prettier": "3.4.2",