Skip to content

Docs: Fix constant/function assignment in WP example #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Docs: Fix constant/function assignment in WP example #1094

merged 2 commits into from
Jan 12, 2025

Conversation

tyrann0us
Copy link
Contributor

@tyrann0us tyrann0us commented Dec 10, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update

What is the current behavior? (You can also link to an open issue here)
In the WordPress code example, lists of constants are assigned to exclude-functions, and lists of functions are assigned to exclude-constants. Also, there are typos: "Wordpress".

What is the new behavior (if this is a feature change)?
Correctly assign constants to exclude-constants and functions to exclude-functions. Change variable naming to camelCase as part of the Boy Scout rule.
Also, fix typos to "WordPress".

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
The scope of the PR changed from fixing the typos to fixing the constants/functions list assignment.

@tyrann0us tyrann0us changed the title Typo in "WordPress" Docs: Fix constant/function assignment in WP example Dec 10, 2024
@tyrann0us
Copy link
Contributor Author

Hi @theofidry, could I ask you to check this PR? Thank you! 🙏🏽

@theofidry theofidry merged commit aff0ef9 into humbug:main Jan 12, 2025
@theofidry
Copy link
Member

Thank you @tyrann0us!

@tyrann0us tyrann0us deleted the patch-1 branch January 20, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants