Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types field in package.json should be dist/index.d.ts #55

Closed
yifanwww opened this issue Aug 3, 2022 · 0 comments · Fixed by #67
Closed

types field in package.json should be dist/index.d.ts #55

yifanwww opened this issue Aug 3, 2022 · 0 comments · Fixed by #67

Comments

@yifanwww
Copy link

yifanwww commented Aug 3, 2022

Currently the types field targets to types/bmapgl/index.d.ts where defines GL JSAPI types in BMapGL namespace. There is a problem when we import this package:

image

Because of the types field, TypeScript can only find the BMapGL namespace in this package, all the types from the src are not exposed.

I think the types field should be dist/index.d.ts (not the previous dist/types/index.d.ts). If users complain they cannot get the type declarations for BMapGL, they should install @types/bmapgl.

This doc in this repo talks about the relations between types/bmapgl and @types/bmapgl. Users can just get BMapGL type definitions from @types/bmapgl, not from this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant