Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSFT hotfix - adds gen prompt to template and processor to hub #1532

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

edbeeching
Copy link
Collaborator

Fixes two things that were missing from the vsft script:

  • Adds generation prompt to the Chat template
  • Adds processor push to hub at end of script

@edbeeching edbeeching requested a review from lewtun April 12, 2024 13:32
@edbeeching edbeeching changed the title adds gen prompt to template and processor to hub VSFT hotfix - adds gen prompt to template and processor to hub Apr 12, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM barring a suggestion to make the push to Hub cleaner

examples/scripts/vsft_llava.py Outdated Show resolved Hide resolved
@edbeeching edbeeching merged commit 1c0d8bc into main Apr 12, 2024
9 checks passed
@edbeeching edbeeching deleted the vsft-hotfix branch April 12, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants