Skip to content

add back logging_dir #42013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2025
+11 −0
Merged

add back logging_dir #42013

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a061fdb
add back
SunMarc Nov 4, 2025
56023bd
Apply style fixes
github-actions[bot] Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/transformers/training_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,6 +885,12 @@ class TrainingArguments:
)
},
)
logging_dir: Optional[str] = field(
default=None,
metadata={
"help": "Deprecated and will be removed in v5.2. Set env var `TENSORBOARD_LOGGING_DIR` instead. TensorBoard log directory."
},
)
logging_strategy: Union[IntervalStrategy, str] = field(
default="steps",
metadata={"help": "The logging strategy to use."},
Expand Down Expand Up @@ -1695,6 +1701,11 @@ def __post_init__(self):
if isinstance(self.include_num_input_tokens_seen, bool):
self.include_num_input_tokens_seen = "all" if self.include_num_input_tokens_seen else "no"

if self.logging_dir is not None:
logger.warning(
"`logging_dir` is deprecated and will be removed in v5.2. Please set `TENSORBOARD_LOGGING_DIR` instead."
)

def __str__(self):
self_as_dict = asdict(self)

Expand Down