Skip to content

Conversation

@SunMarc
Copy link
Member

@SunMarc SunMarc commented Nov 4, 2025

What does this PR do?

This PR adds back logging_dir from @BenjaminBossan suggestion. It might be more used than I thought due to its generic name even though users might not be using tensorboard.

@SunMarc
Copy link
Member Author

SunMarc commented Nov 4, 2025

@bot /style

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Style bot fixed some files and pushed the changes.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this, LGTM.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@SunMarc SunMarc merged commit 154d510 into main Nov 4, 2025
24 checks passed
@SunMarc SunMarc deleted the logging-dir-back branch November 4, 2025 15:23
yonigozlan pushed a commit to yonigozlan/transformers that referenced this pull request Nov 7, 2025
* add back

* Apply style fixes

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Abdennacer-Badaoui pushed a commit to Abdennacer-Badaoui/transformers that referenced this pull request Nov 10, 2025
* add back

* Apply style fixes

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants