Skip to content

GraniteMoeHybrid: Allow for only shared expert case. #38801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

shawntan
Copy link
Contributor

@shawntan shawntan commented Jun 12, 2025

What does this PR do?

Allows for the case where GraniteMoeHybrid models have num_local_experts = 0

@shawntan shawntan changed the title Allow for only shared expert case. GraniteMoeHybrid: Allow for only shared expert case. Jun 12, 2025
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - ping me whenever you're ready and you want me to merge it!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@shawntan
Copy link
Contributor Author

@Rocketknight1 did a few more internal tests. Seems good to go!

Thanks a lot!

@Rocketknight1 Rocketknight1 merged commit 5ab0f44 into huggingface:main Jun 16, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants