Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customise the separator used for splicing in DataCollatorWithFlattening #33114

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

beep-bebop
Copy link
Contributor

@beep-bebop beep-bebop commented Aug 26, 2024

What does this PR do?

#31629 added DataCollatorWithFlattening, which packs examples in a small batch into a long sequence and uses -100 to splice the samples and returns position ids for attention calculation.
Since different models may use different token ids for splicing samples during training, for example, when using the Qwen model for post pre-training, short samples can be packed into long samples to speed up training and memory usage, and separated by <|endoftext|>, which token id is 151643. So allowing the user to customise the separator may be a more flexible implementation, allowing the user to use this DataCollator when building the pre-training dataset with different models.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Models:

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, indeed this makes sense.
can you just update the documentation of this datacolator please!

@beep-bebop
Copy link
Contributor Author

LGTM, indeed this makes sense. can you just update the documentation of this datacolator please!

Updated! Feel free to edit if needed:) @ArthurZucker

@ArthurZucker ArthurZucker merged commit 5c84682 into huggingface:main Aug 28, 2024
20 checks passed
@ArthurZucker
Copy link
Collaborator

Thanks 🤗

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Aug 30, 2024
…ng (huggingface#33114)

* Customising the separator used for splicing in DataCollatorWithFlattening

* update DataCollatorWithFlattening docs

---------

Co-authored-by: weifangyuan <i.weifangyuan@yuewen.com>
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Aug 30, 2024
…ng (huggingface#33114)

* Customising the separator used for splicing in DataCollatorWithFlattening

* update DataCollatorWithFlattening docs

---------

Co-authored-by: weifangyuan <i.weifangyuan@yuewen.com>
itazap pushed a commit to NielsRogge/transformers that referenced this pull request Sep 20, 2024
…ng (huggingface#33114)

* Customising the separator used for splicing in DataCollatorWithFlattening

* update DataCollatorWithFlattening docs

---------

Co-authored-by: weifangyuan <i.weifangyuan@yuewen.com>
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
…ng (huggingface#33114)

* Customising the separator used for splicing in DataCollatorWithFlattening

* update DataCollatorWithFlattening docs

---------

Co-authored-by: weifangyuan <i.weifangyuan@yuewen.com>
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
…ng (huggingface#33114)

* Customising the separator used for splicing in DataCollatorWithFlattening

* update DataCollatorWithFlattening docs

---------

Co-authored-by: weifangyuan <i.weifangyuan@yuewen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants