-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
link for optimizer names #32400
link for optimizer names #32400
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Can you run make fixup to fix cis!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ! Thanks for adding @nbroad1881 !
How is it now? |
Did I mess up the rebase? |
@nbroad1881 probably 😓 those are always fun. You can either reset hard or open a PR |
@nbroad1881 From the commit history, it looks like you pushed after rebase but didn't push force (I know because I've done this myself... ). You should be able to force push again to resolve |
Add a note and link to where the user can find more optimizer names easily because there are many more optimizers than are mentioned in the docstring.
f93a301
to
8679705
Compare
Ok I think I fixed it 😅 |
* link for optimizer names Add a note and link to where the user can find more optimizer names easily because there are many more optimizers than are mentioned in the docstring. * make fixup
* link for optimizer names Add a note and link to where the user can find more optimizer names easily because there are many more optimizers than are mentioned in the docstring. * make fixup
* link for optimizer names Add a note and link to where the user can find more optimizer names easily because there are many more optimizers than are mentioned in the docstring. * make fixup
Add a note and link to where the user can find more optimizer names easily because there are many more optimizers than are mentioned in the docstring.
@muellerzr @SunMarc