Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link for optimizer names #32400

Merged
merged 2 commits into from
Aug 20, 2024
Merged

link for optimizer names #32400

merged 2 commits into from
Aug 20, 2024

Conversation

nbroad1881
Copy link
Contributor

Add a note and link to where the user can find more optimizer names easily because there are many more optimizers than are mentioned in the docstring.

@muellerzr @SunMarc

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Can you run make fixup to fix cis!

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Thanks for adding @nbroad1881 !

@nbroad1881
Copy link
Contributor Author

How is it now?

@nbroad1881
Copy link
Contributor Author

Did I mess up the rebase?

@muellerzr
Copy link
Contributor

@nbroad1881 probably 😓 those are always fun. You can either reset hard or open a PR

@amyeroberts
Copy link
Collaborator

@nbroad1881 From the commit history, it looks like you pushed after rebase but didn't push force (I know because I've done this myself... ). You should be able to force push again to resolve

nbroad1881 and others added 2 commits August 20, 2024 14:48
Add a note and link to where the user can find more optimizer names easily because there are many more optimizers than are mentioned in the docstring.
@nbroad1881
Copy link
Contributor Author

Ok I think I fixed it 😅

@nbroad1881 nbroad1881 merged commit 1dde50c into main Aug 20, 2024
9 checks passed
@nbroad1881 nbroad1881 deleted the optim-names branch August 20, 2024 22:28
Titus-von-Koeller pushed a commit to jiqing-feng/transformers that referenced this pull request Aug 21, 2024
* link for optimizer names

Add a note and link to where the user can find more optimizer names easily because there are many more optimizers than are mentioned in the docstring.

* make fixup
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
* link for optimizer names

Add a note and link to where the user can find more optimizer names easily because there are many more optimizers than are mentioned in the docstring.

* make fixup
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
* link for optimizer names

Add a note and link to where the user can find more optimizer names easily because there are many more optimizers than are mentioned in the docstring.

* make fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants