Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing localized READMEs to the copies check #29575

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

khipp
Copy link
Contributor

@khipp khipp commented Mar 10, 2024

What does this PR do?

This PR adds missing localized READMEs to the copies check and fixes inconsistencies in the lists of model architectures.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

@amyeroberts
Copy link
Collaborator

Hi @khipp, thanks for opening this PR!

This highlights a larger issue with README_de.md as all of these models should have been added to this page when the models were added. It's better to address this (why isn't the german readme being updated) than manually adding here.

@khipp khipp changed the title [i18n-de] Update model architectures list Add missing localized READMEs to the copies check Mar 11, 2024
@khipp
Copy link
Contributor Author

khipp commented Mar 11, 2024

@amyeroberts Thank you for pointing out the utility script. I've added the missing checks and updated the PR accordingly.

@khipp khipp force-pushed the update-model-architectures branch from 3664f97 to 7ceca1b Compare March 11, 2024 14:46
@khipp khipp force-pushed the update-model-architectures branch from 7ceca1b to fac0bf9 Compare March 11, 2024 14:48
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing and updating all these readmes!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@amyeroberts amyeroberts merged commit c1e478a into huggingface:main Mar 11, 2024
8 checks passed
@khipp khipp deleted the update-model-architectures branch March 11, 2024 17:26
itazap pushed a commit that referenced this pull request May 14, 2024
* Add missing localized READMEs to the copies check

* Run check to resolve all inconsistencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants