-
Notifications
You must be signed in to change notification settings - Fork 30k
[i18n-KO] Translated index page to Korean #20180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
8985e24
to
90bafec
Compare
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Hey! 만나서 반가워요! Would love to hear more about the project you were working on and how transformers is used in Korea! 🤗 Thanks a lot for your work!
I will be glad to review once you have cleaned up the modified files! 👍🏻 Also cc @eunseojo just FYI 😉 |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Hello @ArthurZucker, 저도 만나서 반가워요! Thank you so much for your warm welcome and guidance.
P.S. My side-project goal is to enhance "google translator-ish" results: to a more friendly, neighbourhood tone in Korean (grammar checking included!) I'm still tinkering, just learning mostly how to get this to work. I have another idea for generating children's books, but for a later time perhaps. Thank you for your interest! |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
2 similar comments
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
93321b2
to
78832cd
Compare
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, thanks a lot for working on this!
docs/source/ko/_config.py
Outdated
# Transformers installation | ||
! pip install transformers datasets | ||
# To install from source instead of the last release, comment the command above and uncomment the following one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to translate the two comments in Korean!
69039c5
to
4a67433
Compare
docs: i18n: first draft of index page docs: fix: first revision of index page docs: i18n: missed section - supported frameworks docs: fix: second revision of index page review by @ArthurZucker refactor: remove untranslated files from korean docs: fix: remove untranslated references from toctree.yml feat: enable korean docs in gh actions docs: feat: add in_translation page as placeholder docs: bug: testing if internal toc need alphabet chars docs: fix: custom english anchor for non-alphanumeric headings review by @sgugger docs: i18n: translate comments on install methods in _config.py docs: refactor: more concise wording for translations
4a67433
to
757022f
Compare
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Thanks for working on this! Excited to see a new doc in Korean! |
docs: i18n: first draft of index page docs: fix: first revision of index page docs: i18n: missed section - supported frameworks docs: fix: second revision of index page review by @ArthurZucker refactor: remove untranslated files from korean docs: fix: remove untranslated references from toctree.yml feat: enable korean docs in gh actions docs: feat: add in_translation page as placeholder docs: bug: testing if internal toc need alphabet chars docs: fix: custom english anchor for non-alphanumeric headings review by @sgugger docs: i18n: translate comments on install methods in _config.py docs: refactor: more concise wording for translations
What does this PR do?
Translated the
Getting started - index.mdx
file of the documentation to Korean. I use transformers for my side-project and wanted to contribute. As a beginner, this seemed appropriate.Some questions:
_toctree.yml
only when translation is complete? Should I delete all other files for a cleaner review?Transformer
and트랜스포머
to describe the model. However, as this is more of a product of HuggingFace I opted not to translate it. May you please let me know which you would prefer?Thank you in advance for your review.
Part of #20179
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sgugger, may you please review this PR?