Ensure tensors are at least 1d for pad and concat #17179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sgugger |
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
reviewed
May 11, 2022
There was a problem hiding this comment.
Thanks for the PR! The fix looks good but we need something that supports more PyTorch versions.
Also, could you add a test that is failing without the fix? Or do we say such a test is going to be the current failing test in #17166 ?
|
let me add a quick unit test |
sgugger
approved these changes
May 11, 2022
|
@sgugger I am not sure what's up with code quality CI. I cannot reformat the file it complains about locally. Any idea what could be causing this? I have removed the changes to the offending file, let's see if that fixes it. |
|
Ok, CI is green now :D |
|
Thanks again! |
Narsil
pushed a commit
to Narsil/transformers
that referenced
this pull request
May 12, 2022
* Ensure tensors are at least 1d for pad and concat * Compatibility * Fix * Fix * Add test * Retrigger CI * Consistency with master * Retrigger CI
ArthurZucker
pushed a commit
to ArthurZucker/transformers
that referenced
this pull request
May 12, 2022
* Ensure tensors are at least 1d for pad and concat * Compatibility * Fix * Fix * Add test * Retrigger CI * Consistency with master * Retrigger CI
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
* Ensure tensors are at least 1d for pad and concat * Compatibility * Fix * Fix * Add test * Retrigger CI * Consistency with master * Retrigger CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensures that tensors are at least 1d in
pad_and_concatenateutility functions, and usesatleast_1dmethods uniformly in the entire file.Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.