Remove unnecessary columns for all dataset types in Trainer
#17166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sgugger |
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
reviewed
May 10, 2022
|
Ah, yeah, we don't need to check whether it's an iterable dataset! Let me fix that |
Yard1
changed the title
IterableDatasets in TrainerTrainer
sgugger
approved these changes
May 11, 2022
Narsil
pushed a commit
to Narsil/transformers
that referenced
this pull request
May 12, 2022
…gface#17166) * Remove unneeded columns for IterableDataset * Add test * Update trainer tests * Edit docstring * Lint * Apply feedback * Apply feedback
ArthurZucker
pushed a commit
to ArthurZucker/transformers
that referenced
this pull request
May 12, 2022
…gface#17166) * Remove unneeded columns for IterableDataset * Add test * Update trainer tests * Edit docstring * Lint * Apply feedback * Apply feedback
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
…gface#17166) * Remove unneeded columns for IterableDataset * Add test * Update trainer tests * Edit docstring * Lint * Apply feedback * Apply feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As discussed with @sgugger offline, this PR adds automatic removal of unnecessary columns for arbitrary dataset types. This mimics the already present logic for removing unnecessary columns from
datasets.Datasets, but uses a wrapper around the data collation function to enable it for other datasets. The end result is intended to be the same for both cases.The implementation is a bit more complex than it really has to be, in order to facilitate the same logging UX as with the
datasets.Datasetcase.Tests have been added/updated where applicable.
Before submitting
Pull Request section?
Was this discussed/approved via a Github issue or the forum? Please add a linkDiscussed on Slack!to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.