Fix segformer reshape last stage #15748
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
There was a problem hiding this comment.
This is indeed a breaking change, and before doing it we should make sure there are no configurations in the wild with this parameter set to False.
I am not sure if anyone has done this because there are no use cases for this.
It's not sufficient, we need to actually be sure before moving forward with this, cc @LysandreJik
NielsRogge
force-pushed
the
fix_segformer_reshape_last_stage
branch
from
932f4a0 to
982ba0b
Compare
| if "reshape_last_stage" in kwargs: | ||
| warnings.warn(DEPRECATION_WARNING, FutureWarning) |
There was a problem hiding this comment.
This warning will be issued for the models in the Hub that contain this in their config. So, those configs should be updated to remove that attribute.
There was a problem hiding this comment.
Yes, can I remove it after we have a new version of Transformers?
NielsRogge
added
the
WIP
What does this PR do?
This PR improves SegFormer by removing the
reshape_last_stageattribute of the configuration. In fact, this attribute was not needed at all.Previously, the
reshape_last_stageargument was set toFalseforSegformerForImageClassificationmodels, however it's perfectly fine to reshape afterwards within this head model.@sgugger I know you'll warn me about this being a breaking change. Here's why I think this change will not have an impact:
reshape_last_stagewas set toTrueby default in the configuration. As this PR only removes the ability to set this toFalse, the only use case in which this might be a breaking change is in case one defined aSegformerModelwithconfig.reshape_last_stage = False. I am not sure if anyone has done this because there are no use cases for this.