Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pegasus Documentation May Conflict With Seq2Seq ReadMe #9257

Closed
kingpalethe opened this issue Dec 22, 2020 · 4 comments
Closed

Pegasus Documentation May Conflict With Seq2Seq ReadMe #9257

kingpalethe opened this issue Dec 22, 2020 · 4 comments
Labels

Comments

@kingpalethe
Copy link

Here, under tips and tricks.....
https://github.com/huggingface/transformers/blob/master/examples/seq2seq/README.md#tips-and-tricks
Both finetuning and eval are 30% faster with --fp16. For that you need to install apex.

But in the documentation...
https://huggingface.co/transformers/master/model_doc/pegasus.html#examples
FP16 is not supported (help/ideas on this appreciated!).

Also in the documentation
https://huggingface.co/transformers/master/model_doc/pegasus.html#examples
Script to fine-tune pegasus on the XSUM dataset.
leads to a 404: https://github.com/huggingface/transformers/blob/master/examples/seq2seq/finetune_pegasus_xsum.sh

@patil-suraj
Copy link
Contributor

Hi @kingpalethe,

In general, for BART and Marian models, training and eval is faster with fp16, except Pegasus and T5 which currently don't work well with fp16

Yes, the fine-tuning script is now moved under examples/research_projects/seq2seq-distillation dir,
https://github.com/huggingface/transformers/tree/master/examples/research_projects/seq2seq-distillation

Thanks for reporting,

Also please note that this script is not maintained anymore and is provided as-is. We only maintain the finetune_trainer.py script now.

@github-actions
Copy link

github-actions bot commented Mar 6, 2021

This issue has been automatically marked as stale and been closed because it has not had recent activity. Thank you for your contributions.

If you think this still needs to be addressed please comment on this thread.

@github-actions github-actions bot closed this as completed Mar 6, 2021
@WybeKoper WybeKoper mentioned this issue Mar 11, 2021
5 tasks
@555296
Copy link

555296 commented Oct 1, 2023

@555296
Copy link

555296 commented Oct 1, 2023

sio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants