Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrecognized keys in rope_scaling for 'rope_type'='dynamic': {'type'} #32916

Closed
2 of 4 tasks
DefTruth opened this issue Aug 21, 2024 · 5 comments · Fixed by #33331
Closed
2 of 4 tasks

Unrecognized keys in rope_scaling for 'rope_type'='dynamic': {'type'} #32916

DefTruth opened this issue Aug 21, 2024 · 5 comments · Fixed by #33331
Labels

Comments

@DefTruth
Copy link

System Info

version 4.44.1

Who can help?

@ArthurZucker

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction

Unrecognized keys in rope_scaling for 'rope_type'='dynamic': {'type'}

Expected behavior

no error, version 4.42.4 is OK, but 4.44.1 raise this error message, config:

"rope_scaling": {
    "factor": 3.0,
    "type": "dynamic"
  }
@DefTruth DefTruth added the bug label Aug 21, 2024
@thepowerfuldeez
Copy link

There has been an update to how rope_scaling key is handled. When llama3.1 came out, transformers refactored RoPE logic #32135

@ArthurZucker
Copy link
Collaborator

Indeed, tho we did try to make things backward compatible. Do you have a reproducer?

@mneilly
Copy link

mneilly commented Aug 30, 2024

FWIW - I see it when loading a vicuna models.

>>> model = AutoModelForCausalLM.from_pretrained('lmsys/longchat-7b-v1.5-32k', do_sample=True)
Unrecognized keys in `rope_scaling` for 'rope_type'='linear': {'type'}
Loading checkpoint shards: 100%
>>> 
model = AutoModelForCausalLM.from_pretrained('lmsys/vicuna-7b-v1.5-16k', do_sample=True)
Unrecognized keys in `rope_scaling` for 'rope_type'='linear': {'type'}
Loading checkpoint shards:   100%
>>> 

@ArthurZucker
Copy link
Collaborator

Yep I can reproduce. cc @gante

@gante
Copy link
Member

gante commented Sep 5, 2024

Yup, can reproduce it too. It is a harmless warning (no impact on model usage), but opening a PR for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants