Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BART] test_generate_fp16 fails after PR#3140 #3265

Closed
sshleifer opened this issue Mar 13, 2020 · 5 comments · Fixed by #3266
Closed

[BART] test_generate_fp16 fails after PR#3140 #3265

sshleifer opened this issue Mar 13, 2020 · 5 comments · Fixed by #3266

Comments

@sshleifer
Copy link
Contributor

passes after git checkout d6de6423 (commit preceding #3140)
Traceback:

                 unfinished_sents.mul_((~eos_in_sents).long())

            # stop when there is a </s> in each sentence, or if we exceed the maximul length
>           if unfinished_sents.max() == 0:
E           RuntimeError: cuda runtime error (716) : misaligned address at /pytorch/aten/src/THC/THCReduceAll.cuh:327

src/transformers/modeling_utils.py:992: RuntimeError

@thomwolf @patrickvonplaten

@sshleifer sshleifer changed the title [BART] test_generate_fp16 fails after #3140 [BART] test_generate_fp16 fails after PR#3140 Mar 13, 2020
@patrickvonplaten
Copy link
Contributor

Interesting - will investigate. Probably something with the device of unfinished_sents then!

@julien-c

@sshleifer
Copy link
Contributor Author

Caused by previously unexposed kwargs changing behavior:
passing

do_sample=False, early_stopping=True

in the unit test fixes them.

@sshleifer sshleifer linked a pull request Mar 13, 2020 that will close this issue
@Laksh1997
Copy link

I'm getting this error @sshleifer

@Laksh1997
Copy link

#5221

@Laksh1997
Copy link

I have early stopping = False, but do_sample = True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants