Skip to content

Commit e4efa64

Browse files
committed
Add comments about artifact names
1 parent 57c4835 commit e4efa64

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

.github/workflows/self-scheduled.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,8 @@ jobs:
7878
steps:
7979
- name: Echo folder ${{ matrix.folders }}
8080
shell: bash
81+
# For folders like `models/bert`, set an env. var. (`matrix_folders`) to `models_bert`, which will be used to
82+
# set the artifact folder names (because the character `/` is not allowed).
8183
run: |
8284
echo "${{ matrix.folders }}"
8385
matrix_folders=${{ matrix.folders }}
@@ -263,6 +265,8 @@ jobs:
263265
CI_SLACK_CHANNEL_ID: ${{ secrets.CI_SLACK_CHANNEL_ID }}
264266
CI_SLACK_CHANNEL_ID_DAILY: ${{ secrets.CI_SLACK_CHANNEL_ID_DAILY }}
265267
CI_SLACK_CHANNEL_DUMMY_TESTS: ${{ secrets.CI_SLACK_CHANNEL_DUMMY_TESTS }}
268+
# We pass `needs.setup.outputs.matrix` as the argument. A processing in `notification_service.py` to change
269+
# `models/bert` to `models_bert` is required, as the artifact names use `_` instead of `/`.
266270
run: |
267271
pip install slack_sdk
268272
python utils/notification_service.py "${{ needs.setup.outputs.matrix }}"

utils/notification_service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,7 @@ def add_path(self, path: str, gpu: str = None):
561561
arguments = sys.argv[1:][0]
562562
try:
563563
models = ast.literal_eval(arguments)
564-
# Need to change from elements like `models/bert` to `models_bert`
564+
# Need to change from elements like `models/bert` to `models_bert` (the ones used as artifact names).
565565
models = [x.replace("models/", "models_") for x in models]
566566
except SyntaxError:
567567
Message.error_out()

0 commit comments

Comments
 (0)