Fix Pylint warnings (#41644)

cyyever · web-flow · commit 080d704af11d · 2025-10-17T13:09:42.000Z
* Fix pylint warnings

Signed-off-by: Yuanyuan Chen &lt;cyyever@outlook.com&gt;

* More fixes

Signed-off-by: Yuanyuan Chen &lt;cyyever@outlook.com&gt;

* Raise with an exception

Signed-off-by: Yuanyuan Chen &lt;cyyever@outlook.com&gt;

---------

Signed-off-by: Yuanyuan Chen &lt;cyyever@outlook.com&gt;
diff --git a/examples/legacy/seq2seq/run_distributed_eval.py b/examples/legacy/seq2seq/run_distributed_eval.py
@@ -252,8 +252,7 @@ def gather_results_from_each_node(num_replicas, save_dir, timeout) -> list[dict[
             return json_data
         except JSONDecodeError:
             continue
-    else:
-        raise TimeoutError("Rank 0 gave up on waiting for other processes")
+    raise TimeoutError("Rank 0 gave up on waiting for other processes")
     # Unreachable
 
 
diff --git a/src/transformers/models/edgetam/configuration_edgetam.py b/src/transformers/models/edgetam/configuration_edgetam.py
@@ -93,8 +93,6 @@ def __init__(
         if isinstance(backbone_config, dict):
             backbone_config["model_type"] = backbone_config.get("model_type", "timm_wrapper")
             backbone_config = CONFIG_MAPPING[backbone_config["model_type"]](**backbone_config)
-        elif isinstance(backbone_config, AutoConfig):
-            backbone_config = backbone_config
         elif backbone_config is None:
             backbone_config = AutoConfig.from_pretrained(
                 "timm/repvit_m1.dist_in1k",
diff --git a/src/transformers/models/edgetam/modular_edgetam.py b/src/transformers/models/edgetam/modular_edgetam.py
@@ -116,8 +116,6 @@ def __init__(
         if isinstance(backbone_config, dict):
             backbone_config["model_type"] = backbone_config.get("model_type", "timm_wrapper")
             backbone_config = CONFIG_MAPPING[backbone_config["model_type"]](**backbone_config)
-        elif isinstance(backbone_config, AutoConfig):
-            backbone_config = backbone_config
         elif backbone_config is None:
             backbone_config = AutoConfig.from_pretrained(
                 "timm/repvit_m1.dist_in1k",
diff --git a/src/transformers/models/qwen2_vl/video_processing_qwen2_vl.py b/src/transformers/models/qwen2_vl/video_processing_qwen2_vl.py
@@ -162,7 +162,7 @@ def sample_frames(
                 )
             max_frames = math.floor(min(max_frames, total_num_frames) / temporal_patch_size) * temporal_patch_size
             num_frames = total_num_frames / metadata.fps * fps
-            num_frames = min(min(max(num_frames, min_frames), max_frames), total_num_frames)
+            num_frames = min(max(num_frames, min_frames), max_frames, total_num_frames)
             num_frames = math.floor(num_frames / temporal_patch_size) * temporal_patch_size
 
         if num_frames > total_num_frames:
diff --git a/src/transformers/models/qwen3_vl/video_processing_qwen3_vl.py b/src/transformers/models/qwen3_vl/video_processing_qwen3_vl.py
@@ -164,7 +164,7 @@ def sample_frames(
                     "Defaulting to `fps=24`. Please provide `video_metadata` for more accurate results."
                 )
             num_frames = int(total_num_frames / metadata.fps * fps)
-            num_frames = min(min(max(num_frames, self.min_frames), self.max_frames), total_num_frames)
+            num_frames = min(max(num_frames, self.min_frames), self.max_frames, total_num_frames)
 
         if num_frames is None:
             num_frames = min(max(total_num_frames, self.min_frames), self.max_frames)
diff --git a/src/transformers/models/switch_transformers/modeling_switch_transformers.py b/src/transformers/models/switch_transformers/modeling_switch_transformers.py
@@ -230,7 +230,6 @@ def __init__(self, config: SwitchTransformersConfig, is_sparse=False):
     def forward(self, hidden_states, **kwargs):
         forwarded_states = self.layer_norm(hidden_states)
         forwarded_states = self.mlp(forwarded_states)
-        forwarded_states = forwarded_states
         output = hidden_states + self.dropout(forwarded_states)
         return output
 
diff --git a/src/transformers/models/switch_transformers/modular_switch_transformers.py b/src/transformers/models/switch_transformers/modular_switch_transformers.py
@@ -250,7 +250,6 @@ def __init__(self, config: SwitchTransformersConfig, is_sparse=False):
     def forward(self, hidden_states, **kwargs):
         forwarded_states = self.layer_norm(hidden_states)
         forwarded_states = self.mlp(forwarded_states)
-        forwarded_states = forwarded_states
         output = hidden_states + self.dropout(forwarded_states)
         return output
 
diff --git a/src/transformers/models/video_llama_3/video_processing_video_llama_3.py b/src/transformers/models/video_llama_3/video_processing_video_llama_3.py
@@ -163,7 +163,7 @@ def sample_frames(
                 )
             max_frames = math.floor(min(max_frames, total_num_frames) / temporal_patch_size) * temporal_patch_size
             num_frames = total_num_frames / metadata.fps * fps
-            num_frames = min(min(max(num_frames, min_frames), max_frames), total_num_frames)
+            num_frames = min(max(num_frames, min_frames), max_frames, total_num_frames)
             num_frames = math.floor(num_frames / temporal_patch_size) * temporal_patch_size
 
         if num_frames > total_num_frames:
diff --git a/src/transformers/pipelines/question_answering.py b/src/transformers/pipelines/question_answering.py
@@ -86,10 +86,10 @@ def decode_spans(
 
 
 def select_starts_ends(
-    start,
-    end,
-    p_mask,
-    attention_mask,
+    start: np.ndarray,
+    end: np.ndarray,
+    p_mask: np.ndarray,
+    attention_mask: np.ndarray,
     min_null_score=1000000,
     top_k=1,
     handle_impossible_answer=False,
diff --git a/tests/models/bart/test_modeling_bart.py b/tests/models/bart/test_modeling_bart.py
@@ -514,7 +514,7 @@ def assert_tensors_close(a, b, atol=1e-12, prefix=""):
     try:
         if torch.allclose(a, b, atol=atol):
             return True
-        raise
+        raise Exception
     except Exception:
         pct_different = (torch.gt((a - b).abs(), atol)).float().mean().item()
         if a.numel() > 100:
diff --git a/tests/models/blenderbot/test_modeling_blenderbot.py b/tests/models/blenderbot/test_modeling_blenderbot.py
@@ -270,7 +270,7 @@ def assert_tensors_close(a, b, atol=1e-12, prefix=""):
     try:
         if torch.allclose(a, b, atol=atol):
             return True
-        raise
+        raise Exception
     except Exception:
         pct_different = (torch.gt((a - b).abs(), atol)).float().mean().item()
         if a.numel() > 100:
diff --git a/tests/models/blenderbot_small/test_modeling_blenderbot_small.py b/tests/models/blenderbot_small/test_modeling_blenderbot_small.py
@@ -275,7 +275,7 @@ def assert_tensors_close(a, b, atol=1e-12, prefix=""):
     try:
         if torch.allclose(a, b, atol=atol):
             return True
-        raise
+        raise Exception
     except Exception:
         pct_different = (torch.gt((a - b).abs(), atol)).float().mean().item()
         if a.numel() > 100:
diff --git a/tests/models/fsmt/test_modeling_fsmt.py b/tests/models/fsmt/test_modeling_fsmt.py
@@ -414,7 +414,7 @@ def _assert_tensors_equal(a, b, atol=1e-12, prefix=""):
     try:
         if torch.allclose(a, b, atol=atol):
             return True
-        raise
+        raise Exception
     except Exception:
         if len(prefix) > 0:
             prefix = f"{prefix}: "
diff --git a/tests/models/led/test_modeling_led.py b/tests/models/led/test_modeling_led.py
@@ -476,7 +476,7 @@ def assert_tensors_close(a, b, atol=1e-12, prefix=""):
     try:
         if torch.allclose(a, b, atol=atol):
             return True
-        raise
+        raise Exception
     except Exception:
         pct_different = (torch.gt((a - b).abs(), atol)).float().mean().item()
         if a.numel() > 100:
diff --git a/tests/models/marian/test_modeling_marian.py b/tests/models/marian/test_modeling_marian.py
@@ -346,7 +346,7 @@ def assert_tensors_close(a, b, atol=1e-12, prefix=""):
     try:
         if torch.allclose(a, b, atol=atol):
             return True
-        raise
+        raise Exception
     except Exception:
         pct_different = (torch.gt((a - b).abs(), atol)).float().mean().item()
         if a.numel() > 100:
diff --git a/tests/models/mbart/test_modeling_mbart.py b/tests/models/mbart/test_modeling_mbart.py
@@ -379,7 +379,7 @@ def assert_tensors_close(a, b, atol=1e-12, prefix=""):
     try:
         if torch.allclose(a, b, atol=atol):
             return True
-        raise
+        raise Exception
     except Exception:
         pct_different = (torch.gt((a - b).abs(), atol)).float().mean().item()
         if a.numel() > 100:
diff --git a/tests/models/mvp/test_modeling_mvp.py b/tests/models/mvp/test_modeling_mvp.py
@@ -521,7 +521,7 @@ def assert_tensors_close(a, b, atol=1e-12, prefix=""):
     try:
         if torch.allclose(a, b, atol=atol):
             return True
-        raise
+        raise Exception
     except Exception:
         pct_different = (torch.gt((a - b).abs(), atol)).float().mean().item()
         if a.numel() > 100:
diff --git a/tests/models/opt/test_modeling_opt.py b/tests/models/opt/test_modeling_opt.py
@@ -341,7 +341,7 @@ def assert_tensors_close(a, b, atol=1e-12, prefix=""):
     try:
         if torch.allclose(a, b, atol=atol):
             return True
-        raise
+        raise Exception
     except Exception:
         pct_different = (torch.gt((a - b).abs(), atol)).float().mean().item()
         if a.numel() > 100:
diff --git a/tests/models/pegasus/test_modeling_pegasus.py b/tests/models/pegasus/test_modeling_pegasus.py
@@ -300,7 +300,7 @@ def assert_tensors_close(a, b, atol=1e-12, prefix=""):
     try:
         if torch.allclose(a, b, atol=atol):
             return True
-        raise
+        raise Exception
     except Exception:
         pct_different = (torch.gt((a - b).abs(), atol)).float().mean().item()
         if a.numel() > 100:
diff --git a/tests/models/pegasus_x/test_modeling_pegasus_x.py b/tests/models/pegasus_x/test_modeling_pegasus_x.py
@@ -545,7 +545,7 @@ def assert_tensors_close(a, b, atol=1e-12, prefix=""):
     try:
         if torch.allclose(a, b, atol=atol):
             return True
-        raise
+        raise Exception
     except Exception:
         pct_different = (torch.gt((a - b).abs(), atol)).float().mean().item()
         if a.numel() > 100:
diff --git a/tests/models/plbart/test_modeling_plbart.py b/tests/models/plbart/test_modeling_plbart.py
@@ -330,7 +330,7 @@ def assert_tensors_close(a, b, atol=1e-12, prefix=""):
     try:
         if torch.allclose(a, b, atol=atol):
             return True
-        raise
+        raise Exception
     except Exception:
         pct_different = (torch.gt((a - b).abs(), atol)).float().mean().item()
         if a.numel() > 100:
diff --git a/tests/models/rag/test_modeling_rag.py b/tests/models/rag/test_modeling_rag.py
@@ -75,7 +75,7 @@ def _assert_tensors_equal(a, b, atol=1e-12, prefix=""):
     try:
         if torch.allclose(a, b, atol=atol):
             return True
-        raise
+        raise Exception
     except Exception:
         msg = f"{a} != {b}"
         if prefix:

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ def sample_frames(`
`162`	`162`	`)`
`163`	`163`	`max_frames = math.floor(min(max_frames, total_num_frames) / temporal_patch_size) * temporal_patch_size`
`164`	`164`	`num_frames = total_num_frames / metadata.fps * fps`
`165`		`- num_frames = min(min(max(num_frames, min_frames), max_frames), total_num_frames)`
	`165`	`+ num_frames = min(max(num_frames, min_frames), max_frames, total_num_frames)`
`166`	`166`	`num_frames = math.floor(num_frames / temporal_patch_size) * temporal_patch_size`
`167`	`167`
`168`	`168`	`if num_frames > total_num_frames:`
Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ def sample_frames(`
`164`	`164`	"Defaulting to `fps=24`. Please provide `video_metadata` for more accurate results."
`165`	`165`	`)`
`166`	`166`	`num_frames = int(total_num_frames / metadata.fps * fps)`
`167`		`- num_frames = min(min(max(num_frames, self.min_frames), self.max_frames), total_num_frames)`
	`167`	`+ num_frames = min(max(num_frames, self.min_frames), self.max_frames, total_num_frames)`
`168`	`168`
`169`	`169`	`if num_frames is None:`
`170`	`170`	`num_frames = min(max(total_num_frames, self.min_frames), self.max_frames)`
Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ def sample_frames(`
`163`	`163`	`)`
`164`	`164`	`max_frames = math.floor(min(max_frames, total_num_frames) / temporal_patch_size) * temporal_patch_size`
`165`	`165`	`num_frames = total_num_frames / metadata.fps * fps`
`166`		`- num_frames = min(min(max(num_frames, min_frames), max_frames), total_num_frames)`
	`166`	`+ num_frames = min(max(num_frames, min_frames), max_frames, total_num_frames)`
`167`	`167`	`num_frames = math.floor(num_frames / temporal_patch_size) * temporal_patch_size`
`168`	`168`
`169`	`169`	`if num_frames > total_num_frames:`