Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cuda graphs for qwen2-vl #2708

Merged
merged 6 commits into from
Nov 1, 2024
Merged

fix cuda graphs for qwen2-vl #2708

merged 6 commits into from
Nov 1, 2024

Conversation

drbh
Copy link
Collaborator

@drbh drbh commented Oct 30, 2024

The PR: adds support for multidimensional position ids on batch to enable cuda graphs on qwen2-vl. This PR is a fast followup to the original support of qwen2-vl: #2689

@drbh drbh force-pushed the qwen2-vl-support-cuda-graphs branch from d0fcb77 to e2b394e Compare October 31, 2024 23:15
@drbh
Copy link
Collaborator Author

drbh commented Oct 31, 2024

thank you again @sywangyi for providing the changes that fix the lm_head_indices and output the correct logits 🙏

ref: fix qwen2 failure in intel cpu

@Narsil Narsil merged commit 01dacf8 into main Nov 1, 2024
10 of 12 checks passed
@Narsil Narsil deleted the qwen2-vl-support-cuda-graphs branch November 1, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants