Skip to content

Fixing incorrect feature name for candle-core #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sohelzerdoumi
Copy link

@sohelzerdoumi sohelzerdoumi commented Jun 2, 2025

What does this PR do?

Fixing wrong features name of candle-core

candle-core/Cargo.toml

# candle-core/Cargo.toml
[features]
default = []
cuda = ["cudarc", "dep:candle-kernels", "dep:ug-cuda"]
cudnn = ["cuda", "cudarc/cudnn"]
mkl = ["dep:libc", "dep:intel-mkl-src"]
accelerate = ["dep:libc", "dep:accelerate-src"]
metal = ["dep:metal", "dep:candle-metal-kernels", "dep:ug-metal"]

Now, we can import and use cuda feature from your repo:

[build-dependencies]
text-embeddings-backend = { git = "https://github.com/huggingface/text-embeddings-inference.git", version = "1.7.0", features = ['cuda'] }

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil
Copy link
Collaborator

Narsil commented Jun 2, 2025

What makes you think they are wrong ?

The code compile perfectly, because we don't live on stock candle but on a branch to enable more complex compilation options which require those features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants