Various cleanups; type hint fixes incl. corresponding to PEP 484 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See towards the bottom of https://peps.python.org/pep-0484/#union-types. It states that in past versions of the PEP, int = None would have been allowed, as it implicitly becomes Optional[int] = None. This is no longer the case, and we need to be explicit.
lewtun
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Thanks for all these fixes @tomaarsen ❤️ ! They LGTM so happy to merge once we resolve the conflicts from some prior PRs getting merged
|
I'll get right on that! |
|
Sorry to be a pain, but only just getting back to this now and there's a new round of merge conflicts to resolve. If you don't mind fixing them, I'll merge this right away! |
|
It seems like we're experiencing some issues with the latest |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Pull request overview
Optionalin accordance to PEP 484.Details
PEP 484 now states that a type hint of
int = Noneis no longer correct. In previous versions, this would have been allowed, as it implicitly becomesOptional[int] = None. This was later changed, requiring us to be explicit withOptional.Each of the changes are small, and for the most part ought to speak for themselves. Please let me know if you have any questions and feel free to review.