Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix merging bug / update boft conv2d scaling variable #2127

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

Zeju1997
Copy link
Contributor

@Zeju1997 Zeju1997 commented Oct 4, 2024

Fixing the bug that boft_s cannot be loaded with older version checkpoints.

@Zeju1997
Copy link
Contributor Author

Zeju1997 commented Oct 4, 2024

@BenjaminBossan I think this should fix the problem. Best.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

I ran pytest tests/regression/test_regression.py -s --regression -k boft on this branch and it passed.

@BenjaminBossan BenjaminBossan merged commit e6f927b into huggingface:main Oct 7, 2024
14 checks passed
BenjaminBossan pushed a commit to BenjaminBossan/peft that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants