FIX [CI / bnb] Fix failing bnb workflow
#1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younesbelkada
changed the title
CI / `bnb] Fix failing bnb workflowCI / bnb] Fix failing bnb workflow
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
younesbelkada
requested review from
BenjaminBossan,
Titus-von-Koeller and
pacman100
|
Is this something that only affects bnb or should we pin pytest in general? |
|
@BenjaminBossan it only affect bnb as we run the bnb transformers tests on the transformers repo |
BenjaminBossan
approved these changes
Feb 19, 2024
|
Thanks for the review @BenjaminBossan ! 🙏 |
BenjaminBossan
pushed a commit
to BenjaminBossan/peft
that referenced
this pull request
Mar 14, 2024
* Update nightly-bnb.yml * Update nightly-bnb.yml * Update nightly-bnb.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the current bnb workflow that is broken due to an incompatible pytest version with transformers leading to transformers tests being silently skipped: https://github.com/huggingface/peft/actions/runs/7945902843/job/21693054056
cc @pacman100 @BenjaminBossan @Titus-von-Koeller FYI