Improve the current chat template system #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
clefourrier
commented
Feb 16, 2024
clefourrier
commented
- adds system prompt
- formats the choices too with assistant template
|
@lewtun I'd love your insight on how we implemented it if possible. |
lewtun
reviewed
Feb 16, 2024
| tokenizer=tokenizer, | ||
| example=example, | ||
| instruction=instruction, | ||
| fewshot_ex=fewshot_ex, |
There was a problem hiding this comment.
Does this wrap the examples in user/assistant turns? I think that was the main thing Eleuther was struggling to agree on vs just putting all the examples in a single user turn
There was a problem hiding this comment.
Yep, we wrap in user/assistant turns! Logic is here: https://github.com/huggingface/lighteval/blob/main/src/lighteval/few_shot_manager.py#L159
NathanHB
approved these changes
Feb 21, 2024
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
- adds system prompt - formats the choices too with assistant template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.