Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilingual NLI Tasks #329

Merged
merged 43 commits into from
Sep 30, 2024
Merged

Multilingual NLI Tasks #329

merged 43 commits into from
Sep 30, 2024

Conversation

hynky1999
Copy link
Collaborator

@hynky1999 hynky1999 commented Sep 25, 2024

Goal

Add 3 NLI tasks supporting 26 unique languages.

While the xnli2.0 is superior I decided to keep xnli, as some people might want to use it.
Since it uses template it support all 3 types of formulation out of the box :)

How to test:

lighteval accelerate --output_dir=./tmp --custom_tasks="lighteval.tasks.multilingual.tasks" --tasks="custom|{task}|0|0" --model_args=pretrained=gpt2 --override_batch_size=1 --max_samples=100 --save_details

where task in indicnxnli_tel_cf xnli_en_cf xnli2.0_en_cf ocnli_zho_cf cmnli_zho_cf rcb_rus_cf

Comments

  • We talked about removing the suite all together. Since right now we use suite I decided to use custom suite. I can switch to multilingual or whatever

@hynky1999 hynky1999 changed the base branch from main to config_templates September 25, 2024 11:12
Copy link
Member

@clefourrier clefourrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, feel free to add a bit more doc (for example, the above arxiv links to the corresponding classes). Suite should also be lighteval for now since we're adding them to the core

src/lighteval/tasks/multilingual/tasks.py Outdated Show resolved Hide resolved
src/lighteval/tasks/multilingual/tasks.py Show resolved Hide resolved
src/lighteval/tasks/multilingual/tasks.py Outdated Show resolved Hide resolved
src/lighteval/tasks/multilingual/tasks.py Outdated Show resolved Hide resolved
src/lighteval/tasks/multilingual/tasks.py Outdated Show resolved Hide resolved
src/lighteval/tasks/multilingual/tasks.py Outdated Show resolved Hide resolved
src/lighteval/tasks/multilingual/tasks.py Outdated Show resolved Hide resolved
src/lighteval/tasks/multilingual/tasks.py Outdated Show resolved Hide resolved
from lighteval.utils.language import Language


# ------------------------------- NLI Tasks ------------------------------- #
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be nice to add just a bit of intro doc at the top of the file to explain what these tasks are overall about (= what is NLI, which datasets are used, etc)

hynky1999 and others added 9 commits September 30, 2024 18:21
Co-authored-by: Clémentine Fourrier <22726840+clefourrier@users.noreply.github.com>
Co-authored-by: Clémentine Fourrier <22726840+clefourrier@users.noreply.github.com>
Co-authored-by: Clémentine Fourrier <22726840+clefourrier@users.noreply.github.com>
Co-authored-by: Clémentine Fourrier <22726840+clefourrier@users.noreply.github.com>
Co-authored-by: Clémentine Fourrier <22726840+clefourrier@users.noreply.github.com>
Co-authored-by: Clémentine Fourrier <22726840+clefourrier@users.noreply.github.com>
Co-authored-by: Clémentine Fourrier <22726840+clefourrier@users.noreply.github.com>
@hynky1999 hynky1999 changed the base branch from config_templates to main September 30, 2024 17:20
@hynky1999 hynky1999 merged commit 551572a into main Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants