[v1.0] Remove imports kept only for backward compatibility (#3350)

* Remove imports kept only for backward compatibility

* fix tests

Author: Wauplin

src/huggingface_hub/fastai_utils.py

@@ -16,7 +16,6 @@
 )
 
 from .utils import logging, validate_hf_hub_args
-from .utils._runtime import _PY_VERSION  # noqa: F401 # for backward compatibility...
 
 
 logger = logging.get_logger(__name__)

src/huggingface_hub/file_download.py

@@ -14,15 +14,8 @@
 
 import httpx
 
-from . import (
-    __version__,  # noqa: F401 # for backward compatibility
-    constants,
-)
+from . import constants
 from ._local_folder import get_local_download_paths, read_download_metadata, write_download_metadata
-from .constants import (
-    HUGGINGFACE_CO_URL_TEMPLATE,  # noqa: F401 # for backward compatibility
-    HUGGINGFACE_HUB_CACHE,  # noqa: F401 # for backward compatibility
-)
 from .errors import (
     FileMetadataError,
     GatedRepoError,
@@ -38,29 +31,15 @@
     WeakFileLock,
     XetFileData,
     build_hf_headers,
-    get_fastai_version,  # noqa: F401 # for backward compatibility
-    get_fastcore_version,  # noqa: F401 # for backward compatibility
-    get_graphviz_version,  # noqa: F401 # for backward compatibility
-    get_jinja_version,  # noqa: F401 # for backward compatibility
-    get_pydot_version,  # noqa: F401 # for backward compatibility
-    get_tf_version,  # noqa: F401 # for backward compatibility
-    get_torch_version,  # noqa: F401 # for backward compatibility
     hf_raise_for_status,
-    is_fastai_available,  # noqa: F401 # for backward compatibility
-    is_fastcore_available,  # noqa: F401 # for backward compatibility
-    is_graphviz_available,  # noqa: F401 # for backward compatibility
-    is_jinja_available,  # noqa: F401 # for backward compatibility
-    is_pydot_available,  # noqa: F401 # for backward compatibility
-    is_tf_available,  # noqa: F401 # for backward compatibility
-    is_torch_available,  # noqa: F401 # for backward compatibility
     logging,
     parse_xet_file_data_from_response,
     refresh_xet_connection_info,
     tqdm,
     validate_hf_hub_args,
 )
 from .utils._http import _adjust_range_header, http_backoff, http_stream_backoff
-from .utils._runtime import _PY_VERSION, is_xet_available  # noqa: F401 # for backward compatibility
+from .utils._runtime import is_xet_available
 from .utils._typing import HTTP_METHOD_T
 from .utils.sha import sha_fileobj
 from .utils.tqdm import _get_progress_bar_context
@@ -250,7 +229,7 @@ def hf_hub_url(
 
     if revision is None:
         revision = constants.DEFAULT_REVISION
-    url = HUGGINGFACE_CO_URL_TEMPLATE.format(
+    url = constants.HUGGINGFACE_CO_URL_TEMPLATE.format(
         repo_id=repo_id, revision=quote(revision, safe=""), filename=quote(filename)
     )
     # Update endpoint if provided

src/huggingface_hub/hf_api.py

@@ -73,27 +73,6 @@
     DiscussionWithDetails,
     deserialize_event,
 )
-from .constants import (
-    DEFAULT_ETAG_TIMEOUT,  # noqa: F401 # kept for backward compatibility
-    DEFAULT_REQUEST_TIMEOUT,  # noqa: F401 # kept for backward compatibility
-    DEFAULT_REVISION,  # noqa: F401 # kept for backward compatibility
-    DISCUSSION_STATUS,  # noqa: F401 # kept for backward compatibility
-    DISCUSSION_TYPES,  # noqa: F401 # kept for backward compatibility
-    ENDPOINT,  # noqa: F401 # kept for backward compatibility
-    INFERENCE_ENDPOINTS_ENDPOINT,  # noqa: F401 # kept for backward compatibility
-    REGEX_COMMIT_OID,  # noqa: F401 # kept for backward compatibility
-    REPO_TYPE_MODEL,  # noqa: F401 # kept for backward compatibility
-    REPO_TYPES,  # noqa: F401 # kept for backward compatibility
-    REPO_TYPES_MAPPING,  # noqa: F401 # kept for backward compatibility
-    REPO_TYPES_URL_PREFIXES,  # noqa: F401 # kept for backward compatibility
-    SAFETENSORS_INDEX_FILE,  # noqa: F401 # kept for backward compatibility
-    SAFETENSORS_MAX_HEADER_LENGTH,  # noqa: F401 # kept for backward compatibility
-    SAFETENSORS_SINGLE_FILE,  # noqa: F401 # kept for backward compatibility
-    SPACES_SDK_TYPES,  # noqa: F401 # kept for backward compatibility
-    WEBHOOK_DOMAIN_T,  # noqa: F401 # kept for backward compatibility
-    DiscussionStatusFilter,  # noqa: F401 # kept for backward compatibility
-    DiscussionTypeFilter,  # noqa: F401 # kept for backward compatibility
-)
 from .errors import (
     BadRequestError,
     GatedRepoError,

tests/test_file_download.py

@@ -355,9 +355,9 @@ def test_hf_hub_url_with_empty_subfolder(self):
             )
         )
 
-    @patch("huggingface_hub.file_download.constants.ENDPOINT", "https://huggingface.co")
+    @patch("huggingface_hub.constants.ENDPOINT", "https://huggingface.co")
     @patch(
-        "huggingface_hub.file_download.HUGGINGFACE_CO_URL_TEMPLATE",
+        "huggingface_hub.constants.HUGGINGFACE_CO_URL_TEMPLATE",
         "https://huggingface.co/{repo_id}/resolve/{revision}/{filename}",
     )
     def test_hf_hub_url_with_endpoint(self):

tests/testing_utils.py

@@ -243,7 +243,7 @@ def rmtree_with_retry(path: Union[str, Path]) -> None:
 
 
 def with_production_testing(func):
-    file_download = patch("huggingface_hub.file_download.HUGGINGFACE_CO_URL_TEMPLATE", ENDPOINT_PRODUCTION_URL_SCHEME)
+    file_download = patch("huggingface_hub.constants.HUGGINGFACE_CO_URL_TEMPLATE", ENDPOINT_PRODUCTION_URL_SCHEME)
     hf_api = patch("huggingface_hub.constants.ENDPOINT", ENDPOINT_PRODUCTION)
     return hf_api(file_download(func))