Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a doc for AWS Neuron in Diffusers #9766

Merged
merged 13 commits into from
Oct 25, 2024

Conversation

JingyaHuang
Copy link
Contributor

What does this PR do?

Add a doc linked to Optimum Neuron to demonstrate how to run diffusers on AWS Neuron devices.

@JingyaHuang
Copy link
Contributor Author

Gently pinging @sayakpaul for review 🤗 .

@sayakpaul sayakpaul requested a review from stevhliu October 24, 2024 15:27
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice, thanks for adding!

I think a little more explanation or description of what Optimum Neuron (can just be a sentence or two) is would be clearer for users that Optimum Neuron is how you should interface with AWS Neuron.

docs/source/en/optimization/neuron.md Outdated Show resolved Hide resolved
docs/source/en/optimization/neuron.md Outdated Show resolved Hide resolved
docs/source/en/optimization/neuron.md Outdated Show resolved Hide resolved
docs/source/en/optimization/neuron.md Outdated Show resolved Hide resolved
docs/source/en/optimization/neuron.md Outdated Show resolved Hide resolved
docs/source/en/optimization/neuron.md Outdated Show resolved Hide resolved
docs/source/en/optimization/neuron.md Outdated Show resolved Hide resolved
JingyaHuang and others added 8 commits October 25, 2024 13:00
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@JingyaHuang
Copy link
Contributor Author

Thanks @stevhliu for the review and suggestions! I added a brief introduction to Optimum Neuron.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more typo and then we can merge!

docs/source/en/optimization/neuron.md Outdated Show resolved Hide resolved
JingyaHuang and others added 2 commits October 25, 2024 17:04
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@stevhliu stevhliu merged commit 52d4449 into huggingface:main Oct 25, 2024
1 check passed
@JingyaHuang JingyaHuang deleted the add-neuron-doc branch October 25, 2024 16:15
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
* start draft

* add doc

* Update docs/source/en/optimization/neuron.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/optimization/neuron.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/optimization/neuron.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/optimization/neuron.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/optimization/neuron.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/optimization/neuron.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/optimization/neuron.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* bref intro of ON

* Update docs/source/en/optimization/neuron.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

---------

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants