Skip to content

Conversation

naykun
Copy link
Contributor

@naykun naykun commented Aug 19, 2025

We observe that conditioning resolution strongly influences the alignment of source and target images. This PR introduces a unified resize logic, resulting in significantly enhanced editing performance.

Please kindly give it a review.
cc @yiyixuxu @a-r-r-o-w @sayakpaul

- update condition reshaping logic to improve editing performance
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@linoytsaban
Copy link
Collaborator

thanks!

since _auto_resize is removed from the preprocessing, should it be removed altogether, here as well?

- remove _auto_resize
@naykun
Copy link
Contributor Author

naykun commented Aug 19, 2025

thanks!

since _auto_resize is removed from the preprocessing, should it be removed altogether, here as well?

Sure, resolved in latest commit.

Copy link
Member

@asomoza asomoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@asomoza asomoza merged commit cc48b93 into huggingface:main Aug 19, 2025
11 checks passed
sayakpaul pushed a commit that referenced this pull request Aug 20, 2025
* fix(qwen-image-edit):
- update condition reshaping logic to improve editing performance

* fix(qwen-image-edit):
- remove _auto_resize
@gluttony-10
Copy link

We observe that conditioning resolution strongly influences the alignment of source and target images. This PR introduces a unified resize logic, resulting in significantly enhanced editing performance.

Please kindly give it a review. cc @yiyixuxu @a-r-r-o-w @sayakpaul

This is an incorrect update. Picture consistency is lost again.

@naykun
Copy link
Contributor Author

naykun commented Aug 20, 2025

We observe that conditioning resolution strongly influences the alignment of source and target images. This PR introduces a unified resize logic, resulting in significantly enhanced editing performance.
Please kindly give it a review. cc @yiyixuxu @a-r-r-o-w @sayakpaul

This is an incorrect update. Picture consistency is lost again.

Could you please share your img, prompt and your experiment setting?

@gluttony-10
Copy link

f7dec461761a500b08b9889e8efab936 #12188 Its right. f9ba41754c98140122b036c2a154457a #12190

@naykun
Copy link
Contributor Author

naykun commented Aug 20, 2025

@gluttony-10 I noticed the two cases use different prompts, and the seeds are not the same—this could lead to different outputs. Also, are you using prompt enhancement? If possible, please share your input image, and I’ll run a local test for comparison.

@gluttony-10
Copy link

@gluttony-10 I noticed the two cases use different prompts, and the seeds are not the same—this could lead to different outputs. Also, are you using prompt enhancement? If possible, please share your input image, and I’ll run a local test for comparison.

Sincere apology, it's a problem with the prompt words. Without tags that remain unchanged, there is a significant difference in consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants