Skip to content

Fix wrong dtype argument name as torch_dtype #11346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

nPeppon
Copy link
Contributor

@nPeppon nPeppon commented Apr 16, 2025

What does this PR do?

In PR Improve load_ip_adapter RAM Usage, while indeed improving ram usage, I believe a small mistake was done in the usage of dtype argument instead of torch_dtype.
For instance when using code from Flux documentation on IP Adapters we can observe the

CLIPVisionModelWithProjection got an unexpected keyword argument 'dtype

In the example provided in original PR it is not using the method from load IP adapter directly but rather from

model = CLIPVisionModelWithProjection.from_pretrained("eramth/ip-adapter",subfolder="sdxl_models/image_encoder",torch_dtype=torch.float16)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed.
@asomoza @hlky as reviewers of original PR

@asomoza
Copy link
Member

asomoza commented Apr 16, 2025

thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@asomoza
Copy link
Member

asomoza commented Apr 16, 2025

failing test are not related to this PR

@asomoza asomoza merged commit 3e59d53 into huggingface:main Apr 16, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants