handle vacuous truth cases #238
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In regex validators (such as number) when the value is undefined (or null) the validator should return success, to comply with the html5 number input. Since this is a breaking change, it will be enabled only using an opt-in flag called "allowEmptyValues". I added tests and updated api.
liorcode
force-pushed
the
handle-vacuous-truth
branch
from
f372573 to
4c01a62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain validators (such as max length, number) when the value is undefined (or null) the validator should return success.
Currently when the value is undefined and the used validator is "number" or "max length", it causes an exception (TypeError: Cannot read property 'constructor' of undefined)
I updated the min/max length and regex validators, and added tests.
(I also believe this should be true for an empty value, but this is a breaking change so I didn't do it for now)