Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace static Qt build for Windows #608

Open
GriffinRichards opened this issue Sep 3, 2024 · 0 comments
Open

Replace static Qt build for Windows #608

GriffinRichards opened this issue Sep 3, 2024 · 0 comments
Labels
release target This should be resolved before the next release

Comments

@GriffinRichards
Copy link
Collaborator

GriffinRichards commented Sep 3, 2024

Currently our Windows release builds use a static build of Qt 6.0.1. A few features are currently disabled on Windows because this Qt build doesn't support them:

  • The Summary Charts feature on the Wild Pokémon tab relies on the QtCharts module, which wasn't linked on this build. Once replaced with a build that does link this module, the feature can be reenabled by adding the module unconditionally here in porymap.pro.
  • The Check for Updates feature relies on the QtNetwork module. This wasn't linked in porymap.pro until after our static Qt build was created, but the Windows build still compiles, so it's possible it does link QtNetwork. In any case the feature doesn't work on Windows releases and is currently disabled. A cursory search of similar issues seemed to imply we need to link OpenSSL as well.
  • There's a handful of features introduced in later Qt versions that we could make use of as well, if we bump our lowest supported version
Repository owner deleted a comment Sep 3, 2024
@GriffinRichards GriffinRichards added the release target This should be resolved before the next release label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release target This should be resolved before the next release
Projects
None yet
Development

No branches or pull requests

1 participant