Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committing map script edits can crash Porymap #476

Open
GriffinRichards opened this issue Oct 12, 2022 · 0 comments
Open

Committing map script edits can crash Porymap #476

GriffinRichards opened this issue Oct 12, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@GriffinRichards
Copy link
Collaborator

  1. Load the example script below
  2. Edit any map block

With the steps above Porymap will crash in MapPixmapItem::paintNormal trying to push new edit history. This will occur at least as far back as the 4.5.0 release (haven't checked beyond that yet). A number of different API functions that commit map changes can do this, sometimes only after doing some Redo/Undo to hit a bad commit.

export function onBlockChanged(x, y, prevBlock, newBlock) {
    map.setWidth(map.getWidth() + 1);
}
@GriffinRichards GriffinRichards added the bug Something isn't working label Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant