Added all possible status values from GH api spec.#1885
Merged
bitwiseman merged 2 commits intohub4j:mainfrom Jul 1, 2024
Merged
Added all possible status values from GH api spec.#1885bitwiseman merged 2 commits intohub4j:mainfrom
bitwiseman merged 2 commits intohub4j:mainfrom
Conversation
Added all possible github workflow run status values specified in https://docs.github.com/en/rest/actions/workflow-runs?apiVersion=2022-11-28
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1885 +/- ##
============================================
+ Coverage 80.79% 81.05% +0.25%
- Complexity 2417 2442 +25
============================================
Files 233 237 +4
Lines 7264 7342 +78
Branches 398 398
============================================
+ Hits 5869 5951 +82
+ Misses 1148 1145 -3
+ Partials 247 246 -1 ☔ View full report in Codecov by Sentry. |
bitwiseman
requested changes
Jun 27, 2024
Member
There was a problem hiding this comment.
This PR exposes a hole in our Enum tests - which should require that at least we have a known count of enum values. Please add this enum to https://github.com/hub4j/github-api/blob/main/src/test/java/org/kohsuke/github/EnumTest.java
😭 It would be great to have tests that actually use any of these values.
bitwiseman
approved these changes
Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added all possible github workflow run status values specified in https://docs.github.com/en/rest/actions/workflow-runs?apiVersion=2022-11-28
Description
The Github REST API allows more values than available in the Status enum for GitWorkflowRuns.
Before submitting a PR:
@linkJavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: