Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new merge methods (squash/rebase) for Github Pull Requests #326

Closed
NicholasBoll opened this issue Jan 4, 2017 · 1 comment
Closed

Support new merge methods (squash/rebase) for Github Pull Requests #326

NicholasBoll opened this issue Jan 4, 2017 · 1 comment

Comments

@NicholasBoll
Copy link

NicholasBoll commented Jan 4, 2017 •
edited
Loading

Note: This is part of a developer preview, so it might be too early to implement.

According the version 3 of the github API, new merge methods (squash and rebase) have been added, merge being the default: https://developer.github.com/v3/pulls/#merge-a-pull-request-merge-button

In GHPullRequest#L294, merge_method could be added to support different merge methods. Either the merge method could be overloaded to support different merge methods or methods for squashing and rebasing could be added.
This was referenced Jan 28, 2017
Merged
Open
@greggian
Copy link
Contributor

Note, merge_method is now out of preview. PR updated accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@greggian @NicholasBoll