Skip to content

Commit 122e684

Browse files
authored
Merge pull request #1353 from T45K/add_github_getRepository_validation
Add GitHub#getRepository validation
2 parents faeddb7 + 68d3f70 commit 122e684

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

src/main/java/org/kohsuke/github/GitHub.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -667,7 +667,7 @@ public PagedIterable<GHOrganization> listOrganizations(final String since) {
667667
*/
668668
public GHRepository getRepository(String name) throws IOException {
669669
String[] tokens = name.split("/");
670-
if (tokens.length < 2) {
670+
if (tokens.length != 2) {
671671
throw new IllegalArgumentException("Repository name must be in format owner/repo");
672672
}
673673
return GHRepository.read(this, tokens[0], tokens[1]);

src/test/java/org/kohsuke/github/GitHubTest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,14 @@ public void getRepository() throws IOException {
3535

3636
try {
3737
gitHub.getRepository("hub4j_github-api");
38+
fail();
39+
} catch (IllegalArgumentException e) {
40+
assertThat(e.getMessage(), equalTo("Repository name must be in format owner/repo"));
41+
}
42+
43+
try {
44+
gitHub.getRepository("hub4j/github/api");
45+
fail();
3846
} catch (IllegalArgumentException e) {
3947
assertThat(e.getMessage(), equalTo("Repository name must be in format owner/repo"));
4048
}

0 commit comments

Comments
 (0)