Changing Reddwarf client to use its own request function. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TimSimpsonR
commented
May 2, 2012
TimSimpsonR
commented
- Nova client changed in a way that broke our client, so copying the code from there is necessary.
- Adding InstanceStatus class with the status strings.
Collaborator
|
hmm we might want to push back or find out why that change happened in nova-client...btw +1 on this. |
|
I agree with @rnirmal we need to find out why they thought that was a good idea. |
Collaborator
Author
|
Quick note: I changed this a bit after I realized my fix broke the Exception types inherited from the Nova client. The tests run clean green in fake mode now. @cp16net and @rnirmal Their change makes sense, they wanted to be sure codes from 400 up which were not explicitly handled by a custom exception type (such as 422, in their case) would get some kind of default exception. Maybe we could see about merging our UnprocessableEntity exception into the Nova client code base. |
|
Yes. Yes, do this. |
* Nova client changed in a way that broke our client, so copying the code from there is necessary. * Adding InstanceStatus class with the status strings. * Moved the Dbaas and ReddwarfHTTPClient into their own module. * Changed exceptions module to check Nova's exception map after first looking in Reddwarf's.
hub-cap
added a commit
that referenced
this pull request
May 2, 2012
Changing Reddwarf client to use its own request function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.