Skip to content

Commit 663e8e2

Browse files
committed
3DS: Don't detach autosave thread (fixes mgba-emu#3561)
This leads to a double-free
1 parent bcda207 commit 663e8e2

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGES

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ Emulation fixes:
4040
- GBA Video: Fix edge case with double-height sprites wrapping (fixes mgba.io/i/2824)
4141
- GBA Video: VCOUNTER flag should be updated on DISPSTAT write (fixes mgba.io/i/1873)
4242
Other fixes:
43+
- 3DS: Don't detach autosave thread (fixes mgba.io/i/3561)
4344
- Core: Fix inconsistencies with setting game-specific overrides (fixes mgba.io/i/2963)
4445
- Debugger: Fix writing to specific segment in command-line debugger
4546
- GB Video: Fix video log replaying freezing when video is disabled

src/platform/3ds/main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1066,7 +1066,7 @@ int main(int argc, char* argv[]) {
10661066
ConditionInit(&runner.autosave.cond);
10671067

10681068
APT_SetAppCpuTimeLimit(20);
1069-
runner.autosave.thread = threadCreate(mGUIAutosaveThread, &runner.autosave, 0x2000, 0x1F, 1, true);
1069+
runner.autosave.thread = threadCreate(mGUIAutosaveThread, &runner.autosave, 0x2000, 0x1F, 1, false);
10701070

10711071
Thread thread2;
10721072
if (ThreadCreate(&thread2, _core2Test, NULL) == 0) {

0 commit comments

Comments
 (0)