Skip to content

Commit c01e107

Browse files
authored
Merge pull request kubernetes#137169 from danwinship/revert-nftables-fix
Revert nftables fix for nftables 1.1.3
2 parents 3225252 + 219c13a commit c01e107

File tree

12 files changed

+230
-1267
lines changed

12 files changed

+230
-1267
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ require (
115115
k8s.io/system-validators v1.12.1
116116
k8s.io/utils v0.0.0-20260210185600-b8788abfbbc2
117117
sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730
118-
sigs.k8s.io/knftables v0.0.20
118+
sigs.k8s.io/knftables v0.0.17
119119
sigs.k8s.io/randfill v1.0.0
120120
sigs.k8s.io/structured-merge-diff/v6 v6.3.2
121121
sigs.k8s.io/yaml v1.6.0

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -507,8 +507,8 @@ sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.34.0 h1:hSfpvjjTQXQY2
507507
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.34.0/go.mod h1:Ve9uj1L+deCXFrPOk1LpFXqTg7LCFzFso6PA48q/XZw=
508508
sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730 h1:IpInykpT6ceI+QxKBbEflcR5EXP7sU1kvOlxwZh5txg=
509509
sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730/go.mod h1:mdzfpAEoE6DHQEN0uh9ZbOCuHbLK5wOm7dK4ctXE9Tg=
510-
sigs.k8s.io/knftables v0.0.20 h1:eU2NWpgcJ/wgb4Fy0cX3klK6nDjERvZRdYgkORLU0Tc=
511-
sigs.k8s.io/knftables v0.0.20/go.mod h1:f/5ZLKYEUPUhVjUCg6l80ACdL7CIIyeL0DxfgojGRTk=
510+
sigs.k8s.io/knftables v0.0.17 h1:wGchTyRF/iGTIjd+vRaR1m676HM7jB8soFtyr/148ic=
511+
sigs.k8s.io/knftables v0.0.17/go.mod h1:f/5ZLKYEUPUhVjUCg6l80ACdL7CIIyeL0DxfgojGRTk=
512512
sigs.k8s.io/kustomize/api v0.21.1 h1:lzqbzvz2CSvsjIUZUBNFKtIMsEw7hVLJp0JeSIVmuJs=
513513
sigs.k8s.io/kustomize/api v0.21.1/go.mod h1:f3wkKByTrgpgltLgySCntrYoq5d3q7aaxveSagwTlwI=
514514
sigs.k8s.io/kustomize/cmd/config v0.21.1/go.mod h1:7yEFYBJyBJlpZQ50VaRGQRtFMn3Vzn9Fb2wts4TCok4=

pkg/proxy/nftables/proxier.go

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1109,20 +1109,24 @@ func (proxier *Proxier) syncProxyRules() (retryError error) {
11091109
ipvX_addr = "ipv6_addr"
11101110
}
11111111

1112-
var err error
1113-
11141112
var existingChains sets.Set[string]
1113+
existingChainsList, err := proxier.nftables.List(context.TODO(), "chain")
1114+
if err == nil {
1115+
existingChains = sets.New(existingChainsList...)
1116+
} else {
1117+
proxier.logger.Error(err, "Failed to list existing chains")
1118+
}
11151119
var existingAffinitySets sets.Set[string]
1116-
if allObjects, err := proxier.nftables.ListAll(context.TODO()); err == nil {
1117-
existingChains = sets.New(allObjects["chain"]...)
1120+
existingSets, err := proxier.nftables.List(context.TODO(), "sets")
1121+
if err == nil {
11181122
existingAffinitySets = sets.New[string]()
1119-
for _, set := range allObjects["set"] {
1123+
for _, set := range existingSets {
11201124
if isAffinitySetName(set) {
11211125
existingAffinitySets.Insert(set)
11221126
}
11231127
}
11241128
} else {
1125-
proxier.logger.Error(err, "Failed to list existing nftables objects")
1129+
proxier.logger.Error(err, "Failed to list existing sets")
11261130
}
11271131

11281132
// Accumulate service/endpoint chains and affinity sets to keep.

vendor/modules.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1208,7 +1208,7 @@ sigs.k8s.io/apiserver-network-proxy/konnectivity-client/proto/client
12081208
## explicit; go 1.23
12091209
sigs.k8s.io/json
12101210
sigs.k8s.io/json/internal/golang/encoding/json
1211-
# sigs.k8s.io/knftables v0.0.20
1211+
# sigs.k8s.io/knftables v0.0.17
12121212
## explicit; go 1.20
12131213
sigs.k8s.io/knftables
12141214
# sigs.k8s.io/kustomize/api v0.21.1

vendor/sigs.k8s.io/knftables/CHANGELOG.md

Lines changed: 0 additions & 55 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/sigs.k8s.io/knftables/CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/sigs.k8s.io/knftables/README.md

Lines changed: 23 additions & 93 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)