Skip to content

Commit 7d90d02

Browse files
authored
Merge pull request MyEtherWallet#3007 from MyEtherWallet/develop
release/v5.7.27
2 parents b14fe9d + 5e0728b commit 7d90d02

File tree

9 files changed

+1138
-20188
lines changed

9 files changed

+1138
-20188
lines changed

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
### Release v5.7.27
2+
3+
### Bug
4+
5+
* Fix mnemonic address generation with Extra word on mew cx [#3002](https://github.com/MyEtherWallet/MyEtherWallet/pull/3002)
6+
* Fix path for Avalanche [#2897](https://github.com/MyEtherWallet/MyEtherWallet/pull/2897)
7+
* fix checking estimateGas after estimateGas failure [#3005](https://github.com/MyEtherWallet/MyEtherWallet/pull/3005)
8+
19
### Release v5.7.26
210

311
### Bug

fetchLists/lists/tokens.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

package-lock.json

Lines changed: 1113 additions & 20174 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "myetherwallet",
3-
"version": "5.7.26",
3+
"version": "5.7.27",
44
"description": "Client side ethereum wallet",
55
"scripts": {
66
"build:offline": "WEBPACK_INTEGRITY=false npm run build:hash",
@@ -36,6 +36,7 @@
3636
"@coolwallets/eth": "0.2.0-beta.1",
3737
"@coolwallets/transport-web-ble": "0.1.0",
3838
"@coolwallets/wallet": "0.2.0-beta.1",
39+
"@myetherwallet/mewconnect-web-client": "2.1.23-beta.8",
3940
"@sentry/browser": "6.2.5",
4041
"@sentry/integrations": "6.2.5",
4142
"@unstoppabledomains/resolution": "2.1.1",
@@ -90,7 +91,7 @@
9091
"@makerdao/dai-plugin-mcd": "1.5.9",
9192
"@makerdao/dai-plugin-migrations": "1.3.3",
9293
"@myetherwallet/eth-token-balance": "0.2.2",
93-
"@myetherwallet/mewconnect-web-client": "2.1.7",
94+
"@myetherwallet/eth2-keystore": "0.2.3",
9495
"@stripe/stripe-js": "1.12.1",
9596
"@vue/cli-plugin-babel": "4.5.6",
9697
"@vue/cli-plugin-eslint": "4.5.6",
@@ -169,8 +170,7 @@
169170
"webpack": "4.44.2",
170171
"weekstart": "1.1.0",
171172
"worker-loader": "3.0.2",
172-
"zxcvbn": "4.4.2",
173-
"@myetherwallet/eth2-keystore": "0.2.3"
173+
"zxcvbn": "4.4.2"
174174
},
175175
"engines": {
176176
"node": ">= 10.0.0 < 12.0.0",

src/helpers/ExtensionHelpers.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@ const getAccounts = callback => {
99
chrome.storage.sync.get(null, callback);
1010
};
1111

12-
const getPrivFromMnemonicWallet = async (mnem, path) => {
13-
const wallet = await MnemonicWallet(mnem, '');
12+
const getPrivFromMnemonicWallet = async (mnem, path, password) => {
13+
const receivedPassword = password && password !== '' ? password : '';
14+
const wallet = await MnemonicWallet(mnem, receivedPassword);
1415
return wallet.hdKey.derive(path ? path : wallet.basePath).privateKey;
1516
};
1617

src/layouts/ExtensionBrowserAction/components/AddWalletModal/AddWalletModal.vue

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -848,7 +848,8 @@ export default {
848848
this.loading = true;
849849
const privateKey = await ExtensionHelpers.getPrivFromMnemonicWallet(
850850
this.wallet.mnemonic,
851-
this.selectedAddressPath
851+
this.selectedAddressPath,
852+
this.extraWord
852853
);
853854
854855
this.loading = false;
@@ -857,6 +858,7 @@ export default {
857858
false,
858859
privKeyType
859860
);
861+
this.extraWord = '';
860862
this.step += 1;
861863
},
862864
getWalletFromMnemonic() {
@@ -867,7 +869,6 @@ export default {
867869
this.extraWord
868870
)
869871
.then(wallet => {
870-
this.extraWord = '';
871872
this.loading = false;
872873
this.wallet = wallet;
873874
this.mnemonicPhraseHolder = {};

src/layouts/InterfaceLayout/containers/SendCurrencyContainer/SendCurrencyContainer.vue

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@
149149
<div class="submit-button-container">
150150
<div
151151
:class="[
152-
validInputs ? '' : 'disabled',
152+
validInputs && isValidGasLimit ? '' : 'disabled',
153153
'submit-button large-round-button-green-filled'
154154
]"
155155
@click="submitTransaction"
@@ -346,7 +346,7 @@ export default {
346346
return (
347347
this.isValidAmount.valid &&
348348
this.isValidAddress &&
349-
new BigNumber(this.gasLimit).gte(0) &&
349+
new BigNumber(this.gasLimit).gte(-1) &&
350350
Misc.validateHexString(this.toData)
351351
);
352352
},
@@ -383,6 +383,7 @@ export default {
383383
return (
384384
this.toValue,
385385
this.isValidAddress,
386+
this.address,
386387
this.toData,
387388
this.selectedCurrency,
388389
new Date().getTime() / 1000

src/wallets/bip44/paths.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ const ethercore = {
152152
label: 'EtherCore'
153153
};
154154
const avalanche = {
155-
path: "m/44'/9000'/0'/0",
155+
path: "m/44'/60'/0'/0",
156156
label: 'Avalanche'
157157
};
158158
export {

src/wallets/hardware/ledger/appPaths.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,12 +178,12 @@ const appList = [
178178
},
179179
{
180180
network: AVAX,
181-
prefixes: ["m/44'/9000'"],
181+
prefixes: ["m/44'/60'"],
182182
paths: [avalanche]
183183
},
184184
{
185185
network: AVAXTEST,
186-
prefixes: ["m/44'/9000'"],
186+
prefixes: ["m/44'/60'"],
187187
paths: [avalanche]
188188
}
189189
];

0 commit comments

Comments
 (0)