chore(lint): apply clippy recommendations

Author: LeoBorai

src/addon/cors.rs

@@ -19,7 +19,7 @@ use crate::config::cors::CorsConfig;
 /// Access-Control-Request-Method header
 ///
 /// Refer to CORS here: https://www.w3.org/wiki/CORS
-#[derive(Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, Default, PartialEq, Eq)]
 pub struct Cors {
     /// The Access-Control-Allow-Credentials response header tells browsers
     /// whether to expose the response to frontend JavaScript code when the
@@ -160,21 +160,6 @@ impl Cors {
     }
 }
 
-impl Default for Cors {
-    fn default() -> Self {
-        Cors {
-            allow_origin: None,
-            allow_methods: None,
-            allow_headers: None,
-            allow_credentials: false,
-            max_age: None,
-            expose_headers: None,
-            request_headers: None,
-            request_method: None,
-        }
-    }
-}
-
 /// CorsConfig Builder
 pub struct CorsBuilder {
     config: Cors,

src/addon/file_server/mod.rs

@@ -149,7 +149,7 @@ impl<'a> FileServer {
         let entries = read_dir(path).context("Unable to read directory")?;
         let mut directory_entries: Vec<DirectoryEntry> = Vec::new();
 
-        for entry in entries.into_iter() {
+        for entry in entries {
             let entry = entry.context("Unable to read entry")?;
             let metadata = entry.metadata()?;
             let created_at = if let Ok(time) = metadata.created() {

src/config/compression.rs

@@ -1,12 +1,6 @@
 use serde::Deserialize;
 
-#[derive(Clone, Debug, Deserialize, PartialEq, Eq)]
+#[derive(Clone, Debug, Default, Deserialize, PartialEq, Eq)]
 pub struct CompressionConfig {
     pub gzip: bool,
 }
-
-impl Default for CompressionConfig {
-    fn default() -> Self {
-        CompressionConfig { gzip: false }
-    }
-}

src/config/file.rs

@@ -37,7 +37,7 @@ impl ConfigFile {
             Ok(config) => Ok(config),
             Err(err) => Err(Error::msg(format!(
                 "Failed to parse config from file. {}",
-                err.to_string()
+                err
             ))),
         }
     }

src/config/tls.rs

@@ -10,6 +10,7 @@ use super::util::tls::{load_cert, load_private_key, PrivateKeyAlgorithm};
 pub struct TlsConfig {
     cert: Vec<Certificate>,
     key: PrivateKey,
+    #[allow(dead_code)]
     key_algorithm: PrivateKeyAlgorithm,
 }
 

src/config/util/tls.rs

@@ -40,7 +40,7 @@ pub fn load_cert(path: &Path) -> Result<Vec<Certificate>> {
         .fill_buf()
         .context("Failed to read cerficate bytes.")?;
 
-    ensure!(bytes.len() == 0, "The provided certificate is empty");
+    ensure!(bytes.is_empty(), "The provided certificate is empty");
 
     let mut reader = Reader::init(bytes);
 

src/server/https.rs

@@ -27,7 +27,7 @@ impl Https {
             .with_safe_defaults()
             .with_no_client_auth()
             .with_single_cert(certs, private_key)
-            .map_err(|err| anyhow::Error::new(err))?;
+            .map_err(anyhow::Error::new)?;
 
         Ok(Arc::new(config))
     }

src/server/middleware/mod.rs

@@ -41,6 +41,7 @@ pub type MiddlewareAfter = Box<
         + Sync,
 >;
 
+#[derive(Default)]
 pub struct Middleware {
     before: Vec<MiddlewareBefore>,
     after: Vec<MiddlewareAfter>,
@@ -94,15 +95,6 @@ impl Middleware {
     }
 }
 
-impl Default for Middleware {
-    fn default() -> Self {
-        Middleware {
-            before: Vec::new(),
-            after: Vec::new(),
-        }
-    }
-}
-
 impl TryFrom<Arc<Config>> for Middleware {
     type Error = Error;
 

src/server/mod.rs

@@ -77,15 +77,11 @@ impl Server {
             server.with_graceful_shutdown(crate::utils::signal::shutdown_signal());
 
         if self.config.verbose() {
-            println!("Serving HTTP: http://{}", address.to_string());
+            println!("Serving HTTP: http://{}", address);
 
             if self.config.address().ip() == Ipv4Addr::from_str("0.0.0.0").unwrap() {
                 if let Ok(ip) = local_ip_address::local_ip() {
-                    println!(
-                        "Local Network IP: http://{}:{}",
-                        ip.to_string(),
-                        self.config.port()
-                    );
+                    println!("Local Network IP: http://{}:{}", ip, self.config.port());
                 }
             }
         }
@@ -106,7 +102,7 @@ impl Server {
         let server = https_server_builder.make_server(address).await.unwrap();
 
         if self.config.verbose() {
-            println!("Serving HTTPS: {}", address.to_string());
+            println!("Serving HTTPS: {}", address);
         }
 
         if let Err(e) = server