Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stacked overlays] Window scroll is re-enabled when the top overlay is closed irrespective of Bottom overlay. #281

Closed
naagas-syft opened this issue Feb 14, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@naagas-syft
Copy link

Background

We are using stacked overlays. (Modal over Modal).
We disable body-scroll when modal is shown. using --body-scroll:false. This disables body scroll when the modal is opened.
https://github.com/htmlstreamofficial/preline/blob/main/src/plugins/overlay/index.ts#L207

When modal is closed we reset the body scroll behavior. (as shown here:
https://github.com/htmlstreamofficial/preline/blob/main/src/plugins/overlay/index.ts#L262).

Bug

The closing modal should respect the configuration needed by the bottom Modal.

@olegpix
Copy link
Collaborator

olegpix commented Feb 28, 2024

Background

We are using stacked overlays. (Modal over Modal). We disable body-scroll when modal is shown. using --body-scroll:false. This disables body scroll when the modal is opened. https://github.com/htmlstreamofficial/preline/blob/main/src/plugins/overlay/index.ts#L207

When modal is closed we reset the body scroll behavior. (as shown here: https://github.com/htmlstreamofficial/preline/blob/main/src/plugins/overlay/index.ts#L262).

Bug

The closing modal should respect the configuration needed by the bottom Modal.

Thanks for noticing! We will fix this in the next update.

@jahaganiev jahaganiev added the bug Something isn't working label Feb 28, 2024
@jahaganiev
Copy link
Member

Hey @naagas-syft - thanks for reporting the issue. We've just pushed the fixes in the v2.1.0 update. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants