Change changelog task to for direct invocation from external command
#5
Conversation
This primarily changes the function signature of the `changelog` task to always take the revision to start from and the name of the next tag/version. In order to be called externally however, an ember-cli project instance needs to be passed in, which conflicted with the existing 'project' config object. This meant two additional changes: 1. The arguments of helpers to avoid using `this` to make it clear that the project instance may not have originated from the `changelog` command. 2. The existing `project` is now merged with the user config to make one master config object with all relevant options.
|
@slindberg we should probably chat about this, I suspect running with mods to |
| console.log(project); | ||
| return generateChangelog.call(project); | ||
| return generateChangelog(project, tags.latest, tags.next); |
There was a problem hiding this comment.
The usage in this file was actually buggy, it was intended to be used this way:
beforeCommit: generateChangelog
We can account for separation of the tags in a wrapper function layer within either project if necessary.
There was a problem hiding this comment.
I updated this line so that it would reflect my other changes, but like I said before I'd like to avoid making the user add this to their config/release.js, so I think the issue is moot.
|
I think my overall impression is that there are some good ideas in this PR, especially for code organization and flow, but I think it also missed too many things for me to accept as is. Ping me on slack if you want to run through these changes with me later, I think for me to have a better understanding of exactly how you intend it to be used by |
|
Sorry, I should have added a 'WIP' to the description. By battery was running low and I rushed to push out my progress so you could look at it. Definitely not mergable as-is. Let's definitely chat about it. |
The commit message has more details, but this is a start to allow
ember-cli-releaseto call thechangelogtask directly instead of relying on a hook in the release config. Intended to work with this branch of ember-cli-release.Right now this is totally untested 🙈