Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python setup.py develop broken #714

Open
breznak opened this issue Oct 9, 2019 · 6 comments
Open

Python setup.py develop broken #714

breznak opened this issue Oct 9, 2019 · 6 comments
Labels
bug Something isn't working build python not py binding, but merge py code in repo

Comments

@breznak
Copy link
Member

breznak commented Oct 9, 2019

I think the develop mode is broken, as it links to build/Release/distr/src
while the changes should be "live" on source files.
Intention of 'develop' py install is that you can make changes to the python files and the package (is linked) will immediately reflect that.

@breznak breznak added bug Something isn't working build python not py binding, but merge py code in repo labels Oct 9, 2019
@breznak
Copy link
Member Author

breznak commented Oct 9, 2019

from pip list

htm.core (2.0.22, /mnt/store/devel/HTM/htm-community/nupic.cpp/build/Release/distr/src)

@breznak
Copy link
Member Author

breznak commented Oct 27, 2019

@dkeeney could you look at this, please? I've recently struggeled with some py code until I realized I was working on an outdated code.

@dkeeney
Copy link

dkeeney commented Nov 7, 2019

PR #747 may fix this. There is a change to setup.py which does a touch of htm.core/bindings/py/cpp_src/CMakeFiles.txt which causes the configure step to re-run before a build. That results in the files being copied into distr/src. There may be a better way to do this but this seems to work without too much additional time for a build.

It still requires at least one of the expansion libs to be deleted before it will build. We might want to remove the step that looks for each of the expansion libs before deciding to call CMake.

@breznak
Copy link
Member Author

breznak commented Nov 8, 2019

Thanks!

It still requires at least one of the expansion libs to be deleted before it will build. We might want to remove the step that looks for each of the expansion libs before deciding to call CMake.

if that would not slow down the build process too much, we should do this.

The idea of develop is to allow changes to py-only files to be appplied without calling anything. I'm not sure if we can still achieve that in which case we could just remove the develop call.

@dkeeney
Copy link

dkeeney commented Nov 8, 2019

Hmmm, I think what is happening is that the develop call is re-packaging the .py code that is already in htm.core/Release/distr/src, not the .py code that might have changed. Somehow we need to copy that code again.

@Zbysekz
Copy link

Zbysekz commented Nov 11, 2019

So if this will work, i can call something like 'python develop install --user --force' and pyfiles will be reflected immediately?

Since now, i was deleting "distr" folder every time and running 'python install --user --force'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build python not py binding, but merge py code in repo
Projects
None yet
Development

No branches or pull requests

3 participants