fix: call screencastOpts as a function for starting a screencast on electron. (cypress-io#23001)

Co-authored-by: Mark Noonan <mark@cypress.io>

Author: 2 people

packages/server/lib/browsers/electron.js

@@ -68,8 +68,7 @@ const _getAutomation = async function (win, options, parent) {
       if (message !== 'take:screenshot') {
         return fn(message, data)
       }
-
-      await sendCommand('Page.startScreencast', screencastOpts)
+      await sendCommand('Page.startScreencast', screencastOpts())
 
       const ret = await fn(message, data)
 
@@ -103,15 +102,14 @@ const _maybeRecordVideo = function (webContents, options) {
     if (!onScreencastFrame) {
       return
     }
-
     webContents.debugger.on('message', (event, method, params) => {
       if (method === 'Page.screencastFrame') {
         onScreencastFrame(params)
         webContents.debugger.sendCommand('Page.screencastFrameAck', { sessionId: params.sessionId })
       }
     })
 
-    await webContents.debugger.sendCommand('Page.startScreencast', screencastOpts)
+    await webContents.debugger.sendCommand('Page.startScreencast', screencastOpts())
   }
 }
 

packages/server/lib/modes/record.js

@@ -791,6 +791,8 @@ const createRunAndRecordSpecs = (options = {}) => {
         })
 
         if (response === responseDidFail) {
+          debug('`responseDidFail` equals `response`, allowing browser to hang until it is killed: Response %o', { responseDidFail })
+
           // dont call the cb, let the browser hang until it's killed
           return
         }