-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing options #5
Conversation
18f63c3
to
6fc66e9
Compare
Thank you for the PR! I just wonder that why you did some changes in |
.gitignore
Outdated
# vscode | ||
.vscode | ||
*code-workspace | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we do not need these changes, It depends on people's environment setup and may vary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... alright, but is that not what .gitignore
is for? I believe you will find similar lines in Fastify's .gitignore
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right but in my opinion, environment-specific things should not be added to gitignore file. If it's project-specific things then good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will revise the gitignore file accordingly. You need to ignore environment-specific files in your global gitignore.
I mean lines 32 and 33 change nothing indeed. Also, role, scope, and request properties assignments (lines 17, 18, 19) are useless unless there is no user object within Fastify request. |
Just being more explicit.
Hmmm... to my knowledge, this is the standard way of going about things. I believe the point is to register the plugin and test that it compiles. Here's an example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gitignore file revertion
355179f
to
6881646
Compare
Thank you @francisdaigle |
Add missing plugin options to TS declaration file.