Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing options #5

Merged
merged 1 commit into from
May 21, 2021
Merged

Conversation

francisdaigle
Copy link
Contributor

Add missing plugin options to TS declaration file.

@hsynlms
Copy link
Owner

hsynlms commented May 21, 2021

Hi @francisdaigle

Thank you for the PR!

I just wonder that why you did some changes in index.test-d.ts?

.gitignore Outdated
# vscode
.vscode
*code-workspace

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do not need these changes, It depends on people's environment setup and may vary.

Copy link
Contributor Author

@francisdaigle francisdaigle May 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... alright, but is that not what .gitignore is for? I believe you will find similar lines in Fastify's .gitignore.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right but in my opinion, environment-specific things should not be added to gitignore file. If it's project-specific things then good to go.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will revise the gitignore file accordingly. You need to ignore environment-specific files in your global gitignore.

@francisdaigle
Copy link
Contributor Author

francisdaigle commented May 21, 2021

Hi @hsynlms

The missing options were added to the TSD test as well.

@hsynlms
Copy link
Owner

hsynlms commented May 21, 2021

I mean lines 32 and 33 change nothing indeed. Also, role, scope, and request properties assignments (lines 17, 18, 19) are useless unless there is no user object within Fastify request.

@francisdaigle
Copy link
Contributor Author

I mean lines 32 and 33 change nothing indeed.

Just being more explicit.

Also, role, scope, and user properties assignments (lines 17, 18, 19) are useless unless there is no user object within Fastify request.

Hmmm... to my knowledge, this is the standard way of going about things. I believe the point is to register the plugin and test that it compiles. Here's an example.

Copy link
Owner

@hsynlms hsynlms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitignore file revertion

@hsynlms hsynlms merged commit 6f80cad into hsynlms:master May 21, 2021
@hsynlms
Copy link
Owner

hsynlms commented May 21, 2021

Thank you @francisdaigle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants