-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ncspot UI flickers, no progress bar for song remaining, and backspace in ':search' prompt doesn't work #934
Comments
Hi, I am able to reproduce the issue. I tested with Xfce Terminal and Alacritty, and the issue doesn't appear. However, when running ncspot inside tmux, the issue appears with both terminals. I was able to record this happening, it looks a bit worse irl but very similar to the recordings: 2022-09-11.20-16-43.mp4Xfce Terminal: 2022-09-11.20-18-36.mp4This didn't happen with the pancurses backend. |
Looks like these could be related: |
Hi there, I have pushed a fix that should hopefully help with this. As I can't reproduce this myself it would be cool if you could report if it helps. Thanks! :) |
Hi @hrkfdn Yup -- that's fixed this issue, thank you. I still cannot delete any characters when pressing backspace, when in a |
@ThomasAdam Hmm, can't really reproduce that backspace issue. Does using a terminal other than xterm also fix this for you? |
Hey @hrkfdn, Yes, alacritty works fine. I suspect the reason it fails in xterm is down to |
Describe the bug
A recent upgrade to ncspot 0.11.0 rendered the main UI unusable. Although ncspot plays songs just fine, the interface flickers continually. Additionally, there is no progress bar indicator at the bottom of the screen, and when trying to use the backspace key in the
:search
prompt, that does not work, hence it is not possible to delete anything.This is all within
xterm
.In investigating this, a
git bisect
betweenv0.10.1
(the known last good/working version), andv0.11.0
indicates that the following commit is where the regression has occurred:I know the problem will probably be within the
termion
repository -- and I will be investigating that next, but I'm also going to raise this issue here, in case it's not.If I use a different terminal (such as
alacritty
), then everything works as expected (the bug does not appear). However, UI libraries should be intelligent enough to handle this, so the suggestion of "use a different terminal", would be too glib.I'm also curious to understand why the backend has been changed?
System (please complete the following information):
The text was updated successfully, but these errors were encountered: