Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening artists with huge discographies takes a long time #477

Closed
nikolaus-stahlberg opened this issue Mar 23, 2021 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@nikolaus-stahlberg
Copy link

nikolaus-stahlberg commented Mar 23, 2021

Opening artists with huge discographies takes a long time.
This is especially noticable when navigating to classical artists, as those will be linked to up to hundereds of albums a year.

Without having studied the code at all, I'd suspect that meta information for artists is queried in full before building the artist page. This is easily fast enough for contemporary music but takes a substanitial amount of time for the big boys of the bygone eras.

Steps to reproduce the behavior:
  • Navigate to 'Tchaikovsky'
  • Open the artists page by hitting o
  • Wait for a long time to proceed

This is probably not of very high concern for now as the program merely hangs for a while but keeps function wonderfully after the artists pages were built.
This is therefore not necessarily a 'breaking-bug' but rather a small inconveniece..

@nikolaus-stahlberg nikolaus-stahlberg added the enhancement New feature or request label Mar 23, 2021
@gbaranski
Copy link

Playing Eminem is not even possible in my case, after pressing ENTER nothing happens.

@hrkfdn
Copy link
Owner

hrkfdn commented Mar 28, 2021

Sounds like the album tab in the artist view should be paginated as well. The download is also taking place in the UI thread.

@hrkfdn hrkfdn added bug Something isn't working and removed enhancement New feature or request labels Mar 28, 2021
@hrkfdn hrkfdn closed this as completed in 0292175 Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants